Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that prevented the throttling settings from displaying for PER_ALERT bucket level trigger actions. #328

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Fixed a bug that prevented the throttling settings from displaying for PER_ALERT bucket level trigger actions. #328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dadd269
Fixed a bug that prevented the throttling settings from displaying fo…
AWSHurneyt Sep 14, 2022
2d5d091
Merge branch 'opensearch-project:main' into main_throttling_fix
AWSHurneyt Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions public/pages/CreateTrigger/components/Action/actions/Message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ export default function Message(
switch (monitorType) {
case MONITOR_TYPE.BUCKET_LEVEL:
displayActionableAlertsOptions = true;
displayThrottlingSettings = actionExecutionScopeId === NOTIFY_OPTIONS_VALUES.PER_ALERT;
actionableAlertsSelections = _.get(values, actionableAlertsSelectionsPath);
break;
case MONITOR_TYPE.DOC_LEVEL:
Expand All @@ -194,6 +195,8 @@ export default function Message(
_.set(values, actionableAlertsSelectionsPath, actionableAlertsSelections);
}

if (!displayThrottlingSettings) _.set(values, `${actionPath}.throttle_enabled`, false);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables throttling if the throttling configurations are not displayed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me after exploring the file.


let preview = '';
try {
preview = Mustache.render(action.message_template.source, context);
Expand Down