Document level monitor UX bug fixes #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
…acknowledging alerts. Fixed bug that was causing the acknowledge modal to render on the monitor details page instead of immediately acknowledging selected alerts. Signed-off-by: AWSHurneyt <[email protected]>
…djusted spacing on action component. Signed-off-by: AWSHurneyt <[email protected]>
…c level monitor. Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
…y names. Fixed a bug that preventing creating a doc level monitor with a notification channel. Signed-off-by: AWSHurneyt <[email protected]>
lezzago
previously approved these changes
Apr 25, 2022
Signed-off-by: AWSHurneyt <[email protected]>
lezzago
approved these changes
Apr 25, 2022
getsaurabh02
approved these changes
Apr 25, 2022
5 tasks
lezzago
pushed a commit
to lezzago/alerting-dashboards-plugin-1
that referenced
this pull request
Apr 26, 2022
* Refactored updateMonitor API to no longer require seqNo or primaryTerm. Signed-off-by: AWSHurneyt <[email protected]> * Fixed bug that was preventing acknowledge modal from refreshing when acknowledging alerts. Fixed bug that was causing the acknowledge modal to render on the monitor details page instead of immediately acknowledging selected alerts. Signed-off-by: AWSHurneyt <[email protected]> * Fixed alerts flyout to render correct pluralization for conditions. Adjusted spacing on action component. Signed-off-by: AWSHurneyt <[email protected]> * Implemented logic to hide anomaly detection option when defining a doc level monitor. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting sending test notifications for doc level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored visual editor to no longer support spaces in tags and query names. Fixed a bug that preventing creating a doc level monitor with a notification channel. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]>
lezzago
added a commit
that referenced
this pull request
Apr 26, 2022
* Document level monitor UX bug fixes (#226) * Refactored updateMonitor API to no longer require seqNo or primaryTerm. Signed-off-by: AWSHurneyt <[email protected]> * Fixed bug that was preventing acknowledge modal from refreshing when acknowledging alerts. Fixed bug that was causing the acknowledge modal to render on the monitor details page instead of immediately acknowledging selected alerts. Signed-off-by: AWSHurneyt <[email protected]> * Fixed alerts flyout to render correct pluralization for conditions. Adjusted spacing on action component. Signed-off-by: AWSHurneyt <[email protected]> * Implemented logic to hide anomaly detection option when defining a doc level monitor. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting sending test notifications for doc level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored visual editor to no longer support spaces in tags and query names. Fixed a bug that preventing creating a doc level monitor with a notification channel. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Add release notes for version 2.0.0-rc1 (#227) * Add release notes for version 2.0.0-rc1 Signed-off-by: Ashish Agrawal <[email protected]> Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Jun 10, 2022
* Document level monitor UX bug fixes (opensearch-project#226) * Refactored updateMonitor API to no longer require seqNo or primaryTerm. Signed-off-by: AWSHurneyt <[email protected]> * Fixed bug that was preventing acknowledge modal from refreshing when acknowledging alerts. Fixed bug that was causing the acknowledge modal to render on the monitor details page instead of immediately acknowledging selected alerts. Signed-off-by: AWSHurneyt <[email protected]> * Fixed alerts flyout to render correct pluralization for conditions. Adjusted spacing on action component. Signed-off-by: AWSHurneyt <[email protected]> * Implemented logic to hide anomaly detection option when defining a doc level monitor. Signed-off-by: AWSHurneyt <[email protected]> * Fixed a bug impacting sending test notifications for doc level monitors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored visual editor to no longer support spaces in tags and query names. Fixed a bug that preventing creating a doc level monitor with a notification channel. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Add release notes for version 2.0.0-rc1 (opensearch-project#227) * Add release notes for version 2.0.0-rc1 Signed-off-by: Ashish Agrawal <[email protected]> Co-authored-by: AWSHurneyt <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.