-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove disabled buttons and update Destination flows to reflect read-only state #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updates in ConfigureActions Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
…stalled Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 53.22% 53.20% -0.03%
==========================================
Files 211 209 -2
Lines 5257 5250 -7
Branches 710 710
==========================================
- Hits 2798 2793 -5
+ Misses 2457 2455 -2
Partials 2 2
Continue to review full report at Codecov.
|
AWSHurneyt
previously approved these changes
Apr 20, 2022
lezzago
previously approved these changes
Apr 20, 2022
…plugin is not installed Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
approved these changes
Apr 20, 2022
AWSHurneyt
approved these changes
Apr 20, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in this PR:
edit
toview
to better convey the read-only stateNote: There are some dangling code paths now (some
onCreate()
andonDelete()
s that are behind removed actions/buttons and routes for the removed Destination API, etc.). These can be removed in follow-up PRs since it's not user accessible.Issues Resolved
Related to opensearch-project/alerting#105
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.