Integrate Alerting Dashboards with Notifications Plugin #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Mohammad Qureshi <[email protected]>
…g/editing Destination objects Signed-off-by: Mohammad Qureshi <[email protected]>
… defining Action Signed-off-by: Mohammad Qureshi <[email protected]>
…g Monitor Signed-off-by: Mohammad Qureshi <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 53.12% 53.22% +0.10%
==========================================
Files 208 211 +3
Lines 5207 5257 +50
Branches 704 710 +6
==========================================
+ Hits 2766 2798 +32
- Misses 2439 2457 +18
Partials 2 2
Continue to review full report at Codecov.
|
Signed-off-by: Mohammad Qureshi <[email protected]>
lezzago
previously approved these changes
Apr 19, 2022
Comment on lines
+26
to
+28
| // export const configToSender = (config: any): SenderItemType => { | ||
| // return { | ||
| // name: config.config.name, |
There was a problem hiding this comment.
Will do a clean-up passthrough in a follow-up
Comment on lines
+8
to
+10
| // NotificationItem, | ||
| // RecipientGroupItemType, | ||
| // SenderItemType, |
praveensameneni
previously approved these changes
Apr 19, 2022
Signed-off-by: Mohammad Qureshi <[email protected]>
lezzago
approved these changes
Apr 19, 2022
praveensameneni
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrates Alerting Dashboards with the Notifications plugin:
ChannelsandDestinationsto support pre-migration scenariosFollow-ups that need to be done in a subsequent PR:
"Learn more"message for Notifications when the Notifications documentation is availableAdd destinationbuttonAdd senderandAdd groupbuttonsdeletebutton for Destinationseditbutton for Destinations toviewand make the fields read-only on the Destination pageUpdatewhen viewing read-only Destinations and changeCancelto beCloseIssues Resolved
Does not completely resolve but related to opensearch-project/alerting#105
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.