Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented UX support for configuring doc level monitors. #218

Merged

Conversation

AWSHurneyt
Copy link
Collaborator

Signed-off-by: AWSHurneyt [email protected]

Description

Refactored existing UX elements to support configuring doc level monitors.

Screenshots

Visual editor UX
localhost_5601_app_home (3)

Extraction query editor UX
localhost_5601_app_home (2)

Monitor details page
localhost_5601_app_home (1)

Alerts by trigger flyout, and finding flyout
localhost_5601_app_home

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt
Copy link
Collaborator Author

The unit test flow is currently failing due to outdated snapshots. yarn run test:jest -u is currently failing to update snapshots locally with the following error:

Test suite failed to run

    The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.
    Consider using the "jsdom" test environment.
    
    ReferenceError: window is not defined

A solution seems to involve adding the following to the top of each test class. There are over 100 test classes at the moment, so that annotation will be added in a separate PR.

/**
 * @jest-environment jsdom
 */

@AWSHurneyt AWSHurneyt marked this pull request as ready for review April 18, 2022 15:48
@AWSHurneyt AWSHurneyt requested a review from a team April 18, 2022 15:48
lezzago
lezzago previously approved these changes Apr 18, 2022
getsaurabh02
getsaurabh02 previously approved these changes Apr 19, 2022
sbcd90
sbcd90 previously approved these changes Apr 19, 2022
AWSHurneyt and others added 3 commits April 18, 2022 18:20
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
…tyle of perform action section of Action element.

Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt AWSHurneyt dismissed stale reviews from sbcd90, getsaurabh02, and lezzago via 57de058 April 19, 2022 01:32
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
lezzago
lezzago previously approved these changes Apr 19, 2022
Signed-off-by: AWSHurneyt <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #218 (8a16d4a) into main (e77eb5f) will decrease coverage by 3.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   56.79%   53.12%   -3.68%     
==========================================
  Files         198      208      +10     
  Lines        4756     5207     +451     
  Branches      651      704      +53     
==========================================
+ Hits         2701     2766      +65     
- Misses       2053     2439     +386     
  Partials        2        2              
Impacted Files Coverage Δ
.../containers/CreateMonitor/utils/monitorToFormik.js 36.11% <0.00%> (-63.89%) ⬇️
.../containers/CreateMonitor/utils/formikToMonitor.js 63.63% <0.00%> (-11.37%) ⬇️
...r/containers/DefineMonitor/utils/searchRequests.js 50.00% <0.00%> (-10.00%) ⬇️
.../containers/CreateTrigger/utils/formikToTrigger.js 32.02% <0.00%> (-7.49%) ⬇️
...reateMonitor/components/MonitorType/MonitorType.js 28.57% <0.00%> (-6.43%) ⬇️
...ateTrigger/components/TriggerQuery/TriggerQuery.js 67.85% <0.00%> (-4.15%) ⬇️
...lTriggerExpression/BucketLevelTriggerExpression.js 54.54% <0.00%> (-3.79%) ⬇️
...omponents/TriggerExpressions/TriggerExpressions.js 60.00% <0.00%> (-3.64%) ⬇️
...fineBucketLevelTrigger/DefineBucketLevelTrigger.js 21.05% <0.00%> (-2.68%) ⬇️
...eTrigger/containers/DefineTrigger/DefineTrigger.js 12.30% <0.00%> (-2.62%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77eb5f...8a16d4a. Read the comment docs.

@AWSHurneyt AWSHurneyt merged commit 259335a into opensearch-project:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants