-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a toast to display successful attempts to acknowledge alerts. Refactored alerts dashboard flyout to refresh its alerts table when alerts are acknowledged. #134
Conversation
…he unit tests workflow.
…rts. Refactored alerts dashboard flyout to refresh its alerts table when alerts are acknowledged. Signed-off-by: Thomas Hurney <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 50.81% 49.76% -1.05%
==========================================
Files 200 201 +1
Lines 4668 4774 +106
Branches 594 600 +6
==========================================
+ Hits 2372 2376 +4
- Misses 2294 2396 +102
Partials 2 2
Continue to review full report at Codecov.
|
…-off-by: Thomas Hurney <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. Let's add some unit tests for the flyout component though before we close this out.
Description
Issues Resolved
#125
Screenshots
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.