Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented a toast to display successful attempts to acknowledge alerts. Refactored alerts dashboard flyout to refresh its alerts table when alerts are acknowledged. #134

Closed
wants to merge 12 commits into from

Conversation

AWSHurneyt
Copy link
Collaborator

@AWSHurneyt AWSHurneyt commented Oct 19, 2021

Description

  1. Implemented a toast to display successful attempts to acknowledge alerts.
  2. Refactored alerts dashboard flyout to refresh its alerts table when alerts are acknowledged.

Issues Resolved

#125

Screenshots

Screen Shot 2021-10-19 at 12 07 30 PM (2)

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #134 (15204aa) into main (e022b96) will decrease coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   50.81%   49.76%   -1.05%     
==========================================
  Files         200      201       +1     
  Lines        4668     4774     +106     
  Branches      594      600       +6     
==========================================
+ Hits         2372     2376       +4     
- Misses       2294     2396     +102     
  Partials        2        2              
Impacted Files Coverage Δ
...gin/public/pages/Dashboard/containers/Dashboard.js 60.00% <0.00%> (-2.50%) ⬇️
...-plugin/public/pages/Dashboard/utils/tableUtils.js 52.17% <0.00%> (ø)
...youts/components/AlertsDashboardFlyoutComponent.js 0.76% <0.00%> (ø)
...lic/pages/Monitors/containers/Monitors/Monitors.js 94.37% <0.00%> (+0.07%) ⬆️
...rds-plugin/public/pages/Dashboard/utils/helpers.js 54.34% <0.00%> (+9.61%) ⬆️
...ublic/components/Flyout/flyouts/alertsDashboard.js 25.00% <0.00%> (+11.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e022b96...15204aa. Read the comment docs.

@AWSHurneyt AWSHurneyt requested a review from lezzago October 19, 2021 22:24
Copy link
Contributor

@qreshi qreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Let's add some unit tests for the flyout component though before we close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants