Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: update category to flatten menus in analytics(all) use case #1114

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Sep 26, 2024

Description

Based on opensearch-project/OpenSearch-Dashboards#8332, alerting needs to make some adjustment to flatten the menus in analytics(all) use case.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: SuZhou-Joe <[email protected]>
@riysaxen-amzn
Copy link
Collaborator

do we know why UTs are failing?

@SuZhou-Joe
Copy link
Member Author

Seems like network issue and you can try rerun the failed CI.

@AWSHurneyt AWSHurneyt merged commit bdda00e into opensearch-project:main Sep 30, 2024
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 30, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit bdda00e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Sep 30, 2024
(cherry picked from commit bdda00e)

Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants