Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look&Feel] apply missing pattern guidance to Alerting experience #1004

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[Look&Feel] apply missing pattern guidance to Alerting experience #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/integration/composite_level_monitor_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe('CompositeLevelMonitor', () => {

// Wait for monitor to be created
cy.wait('@updateMonitorRequest').then(() => {
cy.get('.euiTitle--small').contains(`${SAMPLE_VISUAL_EDITOR_MONITOR}_edited`);
cy.get('.euiText--small').contains(`${SAMPLE_VISUAL_EDITOR_MONITOR}_edited`);
});
});
});
Expand Down
10 changes: 5 additions & 5 deletions public/components/Flyout/flyouts/__snapshots__/flyouts.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ Object {
<EuiFlexItem
className="eui-textTruncate"
>
<EuiTitle
<EuiText
className="eui-textTruncate"
data-test-subj="alertsDashboardFlyout_header_undefined"
size="m"
size="s"
>
<h3>
<h2>
Alerts by undefined
</h3>
</EuiTitle>
</h2>
</EuiText>
</EuiFlexItem>
<EuiFlexItem
grow={false}
Expand Down
10 changes: 5 additions & 5 deletions public/components/Flyout/flyouts/alertsDashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import React from 'react';
import { EuiFlexGroup, EuiButtonIcon, EuiTitle, EuiFlexItem } from '@elastic/eui';
import { EuiFlexGroup, EuiButtonIcon, EuiText, EuiFlexItem } from '@elastic/eui';
import AlertsDashboardFlyoutComponent from './components/AlertsDashboardFlyoutComponent';

const alertsDashboard = (payload) => {
Expand All @@ -20,13 +20,13 @@ const alertsDashboard = (payload) => {
header: (
<EuiFlexGroup justifyContent="flexStart" alignItems="center">
<EuiFlexItem className="eui-textTruncate">
<EuiTitle
<EuiText
className="eui-textTruncate"
size={'m'}
size={'s'}
data-test-subj={`alertsDashboardFlyout_header_${trigger_name}`}
>
<h3>{`Alerts by ${trigger_name}`}</h3>
</EuiTitle>
<h2>{`Alerts by ${trigger_name}`}</h2>
</EuiText>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
Expand Down
2 changes: 1 addition & 1 deletion public/pages/Monitors/components/MonitorActions/MonitorActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export default class MonitorActions extends Component {
panelPaddingSize="none"
anchorPosition="downLeft"
>
<EuiContextMenuPanel items={this.getActions()} />
<EuiContextMenuPanel items={this.getActions()} size="s" />
</EuiPopover>
</EuiFlexItem>
<EuiFlexItem grow={false}>
Expand Down
Loading