Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom-codecs plugin #9944

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Remove custom-codecs plugin #9944

merged 1 commit into from
Sep 8, 2023

Conversation

andrross
Copy link
Member

@andrross andrross commented Sep 8, 2023

This plugin has been moved to its own repository.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change c6a73b9

Incompatible components

Skipped components

Compatible components

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Sep 8, 2023

@andrross

* What went wrong:
Could not determine the dependencies of task ':modules:reindex:bundlePlugin'.
> Task with path 'copyCustomCodecsMetadata' not found in project ':modules:reindex'.

@msfroh
Copy link
Collaborator

msfroh commented Sep 8, 2023

Gradle check failure:

* What went wrong:
Could not determine the dependencies of task ':modules:reindex:bundlePlugin'.
> Task with path 'copyCustomCodecsMetadata' not found in project ':modules:reindex'.

@andrross
Remove custom-codecs plugin
74cba1b 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the remove-custom-codecs branch from c6a73b9 to 74cba1b Compare September 8, 2023 20:12
@andrross andrross added backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch labels Sep 8, 2023
@peterzhuamazon peterzhuamazon mentioned this pull request Sep 8, 2023
Closed
71 tasks
@andrross andrross mentioned this pull request Sep 8, 2023
Merged
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change 74cba1b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

@andrross andrross removed the backport 2.10 Backport to 2.10 branch label Sep 8, 2023
@andrross andrross merged commit 5ad472f into opensearch-project:main Sep 8, 2023
@andrross andrross deleted the remove-custom-codecs branch September 8, 2023 20:58
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9944-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5ad472f0bae642d277211cbed8cc2178449c0f46
# Push it to GitHub
git push --set-upstream origin backport/backport-9944-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9944-to-2.x.

andrross added a commit to andrross/OpenSearch that referenced this pull request Sep 8, 2023
@andrross
Remove custom-codecs plugin (opensearch-project#9944)
6a9e8db 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 5ad472f)
andrross added a commit that referenced this pull request Sep 8, 2023
@andrross
Remove custom-codecs plugin (#9944) (#9948)
7cb6851 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit 5ad472f)
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@andrross @kaushalmahi12
Remove custom-codecs plugin (opensearch-project#9944)
11949f7 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
@andrross @sarthakaggarwal97
Remove custom-codecs plugin (opensearch-project#9944)
dbbf02b 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@andrross @brusic
Remove custom-codecs plugin (opensearch-project#9944)
26df25b 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@andrross @shiv0408
Remove custom-codecs plugin (opensearch-project#9944)
9064a4b 
This plugin has been moved to its own [repository][1].

[1]: https://github.com/opensearch-project/custom-codecs

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrross @reta @msfroh