Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10] Improve performance of rounding dates in date_histogram aggregation #9930

Merged

Conversation

ketanv3
Copy link
Contributor

@ketanv3 ketanv3 commented Sep 8, 2023

Description

Backport of #9727.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…pensearch-project#9727)

* Improve performance of rounding dates in date_histogram aggregation

Signed-off-by: Ketan Verma <[email protected]>

* Minor refactoring changes

Signed-off-by: Ketan Verma <[email protected]>

---------

Signed-off-by: Ketan Verma <[email protected]>
@ketanv3
Copy link
Contributor Author

ketanv3 commented Sep 8, 2023

Proactively created this backport to start off the checks.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change 5ebdf1a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #9930 (5ebdf1a) into 2.10 (6729882) will increase coverage by 0.05%.
The diff coverage is 92.85%.

@@             Coverage Diff              @@
##               2.10    #9930      +/-   ##
============================================
+ Coverage     70.85%   70.91%   +0.05%     
- Complexity    58253    58284      +31     
============================================
  Files          4817     4817              
  Lines        275286   275310      +24     
  Branches      40445    40453       +8     
============================================
+ Hits         195066   195239     +173     
+ Misses        63496    63374     -122     
+ Partials      16724    16697      -27     
Files Changed Coverage Δ
.../src/main/java/org/opensearch/common/Rounding.java 85.02% <92.85%> (+0.37%) ⬆️

... and 471 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@msfroh
Copy link
Collaborator

msfroh commented Sep 8, 2023

Rerunning the failed precommit jobs. While those are sometimes flaky, they tend to be less flaky than Gradle Check

@reta
Copy link
Collaborator

reta commented Sep 8, 2023

Rerunning the failed precommit jobs. While those are sometimes flaky, they tend to be less flaky than Gradle Check

Yeah, those are sadly the network issues :((((

@reta reta merged commit 6f1311b into opensearch-project:2.10 Sep 8, 2023
@DarshitChanpura
Copy link
Member

@reta @msfroh This is merged after code freeze for 2.10 which was Sept 7. This change should be reverted unless is planned and communicated.

@reta
Copy link
Collaborator

reta commented Sep 8, 2023

@reta @msfroh This is merged after code freeze for 2.10 which was Sept 7. This change should be reverted unless is planned and communicated.

Thanks @DarshitChanpura , for some reasons I have got an impression that the date slipped a bit due to disruptive builds infrastructure

reta added a commit that referenced this pull request Sep 8, 2023
reta added a commit that referenced this pull request Sep 8, 2023
@msfroh
Copy link
Collaborator

msfroh commented Sep 8, 2023

I was under the impression that we didn't have a hard freeze starting with this release, but rather a "window" during which RCs would be built. I'll go back and reread the process to make sure I understand what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants