Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Improve performance of rounding dates in date_histogram aggregation #9928

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

ketanv3
Copy link
Contributor

@ketanv3 ketanv3 commented Sep 8, 2023

Description

Backport of #9727.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…pensearch-project#9727)

* Improve performance of rounding dates in date_histogram aggregation

Signed-off-by: Ketan Verma <[email protected]>

* Minor refactoring changes

Signed-off-by: Ketan Verma <[email protected]>

---------

Signed-off-by: Ketan Verma <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Compatibility status:

Checks if related components are compatible with change c8a7466

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #9928 (c8a7466) into 2.x (5258ff2) will increase coverage by 0.02%.
Report is 1 commits behind head on 2.x.
The diff coverage is 93.10%.

@@             Coverage Diff              @@
##                2.x    #9928      +/-   ##
============================================
+ Coverage     70.76%   70.79%   +0.02%     
- Complexity    58217    58232      +15     
============================================
  Files          4817     4817              
  Lines        275286   275311      +25     
  Branches      40445    40453       +8     
============================================
+ Hits         194814   194899      +85     
+ Misses        63820    63751      -69     
- Partials      16652    16661       +9     
Files Changed Coverage Δ
.../src/main/java/org/opensearch/common/Rounding.java 85.02% <92.85%> (-0.10%) ⬇️
...epositories/blobstore/ChecksumBlobStoreFormat.java 95.00% <100.00%> (+0.08%) ⬆️

... and 455 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@reta reta merged commit 529a5b8 into opensearch-project:2.x Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants