Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads #9887

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Sep 7, 2023

Description

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 5425b18

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Compatibility status:

Checks if related components are compatible with change 959c329

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we increase the speed instead as the suite will have to run for a longer time

Sachin Kale added 3 commits September 15, 2023 09:44
@sachinpkale sachinpkale force-pushed the fix-testRateLimitedRemoteDownloads branch from 959c329 to 5425b18 Compare September 15, 2023 04:15
Signed-off-by: Sachin Kale <[email protected]>
@sachinpkale
Copy link
Member Author

Should we increase the speed instead as the suite will have to run for a longer time

Changed.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #9887 (86916cb) into main (e6dec29) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9887      +/-   ##
============================================
+ Coverage     71.03%   71.16%   +0.12%     
- Complexity    58071    58161      +90     
============================================
  Files          4824     4824              
  Lines        273918   273918              
  Branches      39918    39918              
============================================
+ Hits         194591   194924     +333     
+ Misses        63017    62657     -360     
- Partials      16310    16337      +27     

see 473 files with indirect coverage changes

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 60s wait for green not work?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW Thanks a lot Sachin for picking this up :)

@Bukhtawar Bukhtawar merged commit 74fcaab into opensearch-project:main Sep 15, 2023
13 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Sep 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 15, 2023
…oads (#9887)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads

Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit 74fcaab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sachinpkale sachinpkale added the backport 2.10 Backport to 2.10 branch label Sep 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 16, 2023
…oads (#9887)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads

Signed-off-by: Sachin Kale <[email protected]>
(cherry picked from commit 74fcaab)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 16, 2023
…oads (#9887) (#10068)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads


(cherry picked from commit 74fcaab)

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Sep 18, 2023
…oads (#9887) (#10086)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads


(cherry picked from commit 74fcaab)

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
…oads (opensearch-project#9887)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads

Signed-off-by: Sachin Kale <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…oads (opensearch-project#9887)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…oads (opensearch-project#9887)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads

Signed-off-by: Sachin Kale <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…oads (opensearch-project#9887)

* Fix flaky behavior of RemoteStoreRestoreIT.testRateLimitedRemoteDownloads

Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants