Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps jetty version to 9.4.52.v20230823 to fix GMS-2023-1857 #9822

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

DarshitChanpura
Copy link
Member

Fixes GMS-2023-1857.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change bdaf6fc

Incompatible components

Incompatible components: [https://github.com/opensearch-project/k-nn.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change 23703e7

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@DarshitChanpura DarshitChanpura changed the title Bumps jetty version to 12.0.1 to fix GMS-2023-1857 Bumps jetty version to 9.4.52.v20230823 to fix GMS-2023-1857 Sep 14, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@DarshitChanpura
Copy link
Member Author

test failures seem to be flaky.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Sep 14, 2023

@DarshitChanpura could you please rebase? I think those were fixed on main

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #9822 (bdaf6fc) into main (2f7969a) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9822      +/-   ##
============================================
+ Coverage     71.10%   71.13%   +0.03%     
- Complexity    58096    58165      +69     
============================================
  Files          4825     4825              
  Lines        274101   274101              
  Branches      39945    39945              
============================================
+ Hits         194905   194989      +84     
- Misses        62835    62844       +9     
+ Partials      16361    16268      -93     

see 450 files with indirect coverage changes

@reta reta merged commit 0c4e950 into opensearch-project:main Sep 20, 2023
13 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Sep 20, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9822-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0c4e95095e4d44540ea8a90aa5ca55fea1248366
# Push it to GitHub
git push --set-upstream origin backport/backport-9822-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9822-to-2.x.

@reta
Copy link
Collaborator

reta commented Sep 20, 2023

@DarshitChanpura could you please manually backport to 2.x? thank you

sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 24, 2023
…rch-project#9822)

* Bumps jetty version to 12.0.1 to fix GMS-2023-1857

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds this PR to changelog

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates javax websocket server version

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates jetty version to match jetty websocket version

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…rch-project#9822)

* Bumps jetty version to 12.0.1 to fix GMS-2023-1857

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds this PR to changelog

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates javax websocket server version

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates jetty version to match jetty websocket version

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
…rch-project#9822)

* Bumps jetty version to 12.0.1 to fix GMS-2023-1857

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds this PR to changelog

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates javax websocket server version

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates jetty version to match jetty websocket version

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura added a commit to DarshitChanpura/OpenSearch that referenced this pull request Oct 10, 2023
…rch-project#9822)

* Bumps jetty version to 12.0.1 to fix GMS-2023-1857

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds this PR to changelog

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates javax websocket server version

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates jetty version to match jetty websocket version

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 0c4e950)
dblock pushed a commit that referenced this pull request Oct 10, 2023
…10539)

* Bumps jetty version to 12.0.1 to fix GMS-2023-1857

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds this PR to changelog

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates javax websocket server version

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates jetty version to match jetty websocket version

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 0c4e950)
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…rch-project#9822)

* Bumps jetty version to 12.0.1 to fix GMS-2023-1857

Signed-off-by: Darshit Chanpura <[email protected]>

* Adds this PR to changelog

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates javax websocket server version

Signed-off-by: Darshit Chanpura <[email protected]>

* Updates jetty version to match jetty websocket version

Signed-off-by: Darshit Chanpura <[email protected]>

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants