Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Snapshot Interop] Add Logic in Lock Manager to cleanup stale data po… #9769

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[Backport 2.x] [Snapshot Interop] Add Logic in Lock Manager to cleanup stale data po… #9769

merged 1 commit into from
Sep 6, 2023

Conversation

harishbhakuni
Copy link
Contributor

…st index deletion. (#8472)

Signed-off-by: Harish Bhakuni [email protected]
(cherry picked from commit 5670d2a)

Manually Backporting changes of PR #8472 as part of this PR.

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Compatibility status:

Checks if related components are compatible with change be24d5f

Incompatible components

Skipped components

Compatible components

@harishbhakuni harishbhakuni force-pushed the 2.x branch 2 times, most recently from f9c7e09 to 7be4673 Compare September 5, 2023 16:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Compatibility status:

Checks if related components are compatible with change f9c7e09

Incompatible components

Incompatible components: [https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Compatibility status:

Checks if related components are compatible with change 7be4673

Incompatible components

Incompatible components: [https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@harishbhakuni
Copy link
Contributor Author

An unrelated test is failing: org.opensearch.common.blobstore.stream.read.listener.ReadContextListenerTests.testReadContextListenerFailure

@harishbhakuni
Copy link
Contributor Author

#9776

[Snapshot Interop] Add Logic in Lock Manager to cleanup stale data po…
4bbf10e 
…st index deletion. (opensearch-project#8472)

Signed-off-by: Harish Bhakuni <[email protected]>
(cherry picked from commit 5670d2a)
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Compatibility status:

Checks if related components are compatible with change 4bbf10e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #9769 (4bbf10e) into 2.x (b3b1091) will increase coverage by 0.04%.
Report is 4 commits behind head on 2.x.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##                2.x    #9769      +/-   ##
============================================
+ Coverage     70.78%   70.83%   +0.04%     
- Complexity    58006    58094      +88     
============================================
  Files          4802     4805       +3     
  Lines        274034   274440     +406     
  Branches      40315    40340      +25     
============================================
+ Hits         193984   194392     +408     
+ Misses        63435    63375      -60     
- Partials      16615    16673      +58
Files Changed Coverage Δ
...testore/stats/TransportRemoteStoreStatsAction.java 41.02% <0.00%> (-3.42%) ⬇️
...arch/index/remote/RemoteStorePressureSettings.java 87.09% <ø> (ø)
...ore/lockmanager/RemoteStoreLockManagerFactory.java 75.00% <0.00%> (-5.00%) ⬇️
...ain/java/org/opensearch/indices/IndicesModule.java 98.23% <ø> (-0.02%) ⬇️
...ch/repositories/blobstore/BlobStoreRepository.java 58.62% <0.00%> (-0.35%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 68.47% <25.00%> (-0.60%) ⬇️
...main/java/org/opensearch/search/SearchService.java 71.80% <60.00%> (-0.79%) ⬇️
...in/java/org/opensearch/index/ReplicationStats.java 77.41% <77.41%> (ø)
...ch/index/remote/RemoteTranslogTransferTracker.java 78.91% <78.91%> (ø)
...search/index/shard/RemoteStoreRefreshListener.java 86.26% <80.00%> (-1.65%) ⬇️
... and 16 more

... and 468 files with indirect coverage changes

@gbbafna gbbafna merged commit affbd76 into opensearch-project:2.x Sep 6, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harishbhakuni @gbbafna