Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Allow segment replication with on disk files not referenced by reader with matching checksum #9700

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 96e851b from #9630.

…t referenced by reader with matching checksum (#9630)

* [Segment Replication] Allow segment replication with on disk files not referenced by reader with matching checksum

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments

Signed-off-by: Suraj Singh <[email protected]>

* Address review comments

Signed-off-by: Suraj Singh <[email protected]>

* Spotless fix

Signed-off-by: Suraj Singh <[email protected]>

---------

Signed-off-by: Suraj Singh <[email protected]>
(cherry picked from commit 96e851b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Compatibility status:

Checks if related components are compatible with change f542cc0

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

@dreamer-89
Copy link
Member

All recent failures are due to flaky tests. Refiring again!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #9700 (f542cc0) into 2.x (9e41df4) will increase coverage by 0.03%.
Report is 6 commits behind head on 2.x.
The diff coverage is 70.80%.

@@             Coverage Diff              @@
##                2.x    #9700      +/-   ##
============================================
+ Coverage     70.86%   70.89%   +0.03%     
- Complexity    57786    57884      +98     
============================================
  Files          4776     4782       +6     
  Lines        273121   273271     +150     
  Branches      40198    40213      +15     
============================================
+ Hits         193537   193744     +207     
+ Misses        63032    62997      -35     
+ Partials      16552    16530      -22     
Files Changed Coverage Δ
...java/org/opensearch/common/crypto/DataKeyPair.java 0.00% <0.00%> (ø)
...ain/java/org/opensearch/common/unit/TimeValue.java 86.25% <ø> (ø)
...ibs/core/src/main/java/org/opensearch/Version.java 82.45% <ø> (-1.32%) ⬇️
.../src/main/java/org/opensearch/core/ParseField.java 95.65% <ø> (ø)
...ava/org/opensearch/core/action/ActionListener.java 83.17% <0.00%> (+2.80%) ⬆️
...g/opensearch/core/common/bytes/BytesReference.java 74.28% <ø> (ø)
.../core/common/io/stream/NamedWriteableRegistry.java 100.00% <ø> (ø)
.../opensearch/core/common/io/stream/StreamInput.java 88.45% <ø> (-0.40%) ⬇️
...opensearch/core/common/io/stream/StreamOutput.java 94.88% <ø> (-0.81%) ⬇️
.../opensearch/core/common/settings/SecureString.java 78.78% <ø> (ø)
... and 45 more

... and 482 files with indirect coverage changes

@dreamer-89 dreamer-89 merged commit 70cf0f1 into 2.x Sep 3, 2023
@github-actions github-actions bot deleted the backport/backport-9630-to-2.x branch September 3, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant