Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing ZStd compression codec plugin #9658

Merged
merged 18 commits into from
Sep 6, 2023

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Aug 31, 2023

Description

Introduces ZStd Compression Codecs as a plugin

Related Issues

Resolves #9422

Tests Covered:

  • Long running tests to verify for any corruption or memory leaks
  • Backward compatibility test to ensure that the segments that are created in OS 2.9, are readable in OS 2.10 with ZStd as a plugin.
  • Reindexing between different compression codecs
  • Create a snapshot, delete an index, restore from snapshot
  • Split/Shrink api since they modify segments to some extent
  • Index Blocks
  • Upgrade from the minor version
  • Force merge of segments with multiple compression mode into zstd
  • Close an index, update the setting, test the indexing and search flows, snapshots, etc i.e. with multiple compression

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 4218b0e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 3d2835b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the pluginize-zstd branch 2 times, most recently from 4ff3aac to 0d0aea6 Compare August 31, 2023 18:43
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change e9dc084

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 0d0aea6

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 4ff3aac

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 42fdd85

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 8bd83a6

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change f54a80e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change a9512b5

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review August 31, 2023 20:09
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change 443f37a

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

@sarthakaggarwal97
Copy link
Contributor Author

@reta @andrross build is green, please check this out.

@reta
Copy link
Collaborator

reta commented Sep 6, 2023

@reta @andrross build is green, please check this out.

Thanks @sarthakaggarwal97 , still LGTM to me :)

@sarthakaggarwal97
Copy link
Contributor Author

@reta can we merge, and make it in time with for 2.10 release?

@reta
Copy link
Collaborator

reta commented Sep 6, 2023

@reta can we merge, and make it in time with for 2.10 release?

We need @andrross signoff as well

@reta
Copy link
Collaborator

reta commented Sep 6, 2023

💯 ready :-) thanks @andrross & @sarthakaggarwal97 !

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Compatibility status:

Checks if related components are compatible with change 5e92890

Incompatible components

Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.index.ShardIndexingPressureIT.testShardIndexingPressureTrackingDuringBulkWrites

@reta reta merged commit 76f1b52 into opensearch-project:main Sep 6, 2023
@reta reta added backport 2.x Backport to 2.x branch v2.10.0 labels Sep 6, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9658-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 76f1b52647cf19bd19e3ce9d0759953b5d376593
# Push it to GitHub
git push --set-upstream origin backport/backport-9658-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9658-to-2.x.

@reta
Copy link
Collaborator

reta commented Sep 6, 2023

@sarthakaggarwal97 could you please take 2.x backport ? thank you

andrross pushed a commit to andrross/OpenSearch that referenced this pull request Sep 6, 2023
* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Moving zstd compression codec as a plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Adding checks to EngineConfig and fixing tests

Signed-off-by: Prabhakar Sithanandam <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* fixing tests

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

* implementing codec aliases

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* moving codec aliases to custom codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* adding zstd default codec for backward compatibility

Signed-off-by: Sarthak Aggarwal <[email protected]>

* renaming to deprecated codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

---------

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 76f1b52)
andrross added a commit to andrross/OpenSearch that referenced this pull request Sep 6, 2023
* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Moving zstd compression codec as a plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Adding checks to EngineConfig and fixing tests

Signed-off-by: Prabhakar Sithanandam <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* fixing tests

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

* implementing codec aliases

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* moving codec aliases to custom codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* adding zstd default codec for backward compatibility

Signed-off-by: Sarthak Aggarwal <[email protected]>

* renaming to deprecated codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

---------

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 76f1b52)
Signed-off-by: Andrew Ross <[email protected]>
andrross added a commit to andrross/OpenSearch that referenced this pull request Sep 6, 2023
* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Moving zstd compression codec as a plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Adding checks to EngineConfig and fixing tests

Signed-off-by: Prabhakar Sithanandam <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* fixing tests

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

* implementing codec aliases

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* moving codec aliases to custom codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* adding zstd default codec for backward compatibility

Signed-off-by: Sarthak Aggarwal <[email protected]>

* renaming to deprecated codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

---------

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 76f1b52)
Signed-off-by: Andrew Ross <[email protected]>
reta pushed a commit that referenced this pull request Sep 6, 2023
* introducing zstd compression codec plugin



* Moving zstd compression codec as a plugin



* introducing zstd compression codec plugin



* Adding checks to EngineConfig and fixing tests



* incorporating review comments



* fixing tests



* introducing zstd compression codec plugin



* addressing review comments



* nit fixes



* implementing codec aliases



* addressing review comments



* review comments



* moving codec aliases to custom codec



* adding zstd default codec for backward compatibility



* renaming to deprecated codec



* incorporating review comments



* nit fixes



---------






(cherry picked from commit 76f1b52)

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Sarthak Aggarwal <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2023
* introducing zstd compression codec plugin

* Moving zstd compression codec as a plugin

* introducing zstd compression codec plugin

* Adding checks to EngineConfig and fixing tests

* incorporating review comments

* fixing tests

* introducing zstd compression codec plugin

* addressing review comments

* nit fixes

* implementing codec aliases

* addressing review comments

* review comments

* moving codec aliases to custom codec

* adding zstd default codec for backward compatibility

* renaming to deprecated codec

* incorporating review comments

* nit fixes

---------

(cherry picked from commit 76f1b52)

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Sarthak Aggarwal <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
(cherry picked from commit 90310c3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Sep 7, 2023
* introducing zstd compression codec plugin

* Moving zstd compression codec as a plugin

* introducing zstd compression codec plugin

* Adding checks to EngineConfig and fixing tests

* incorporating review comments

* fixing tests

* introducing zstd compression codec plugin

* addressing review comments

* nit fixes

* implementing codec aliases

* addressing review comments

* review comments

* moving codec aliases to custom codec

* adding zstd default codec for backward compatibility

* renaming to deprecated codec

* incorporating review comments

* nit fixes

---------

(cherry picked from commit 76f1b52)






(cherry picked from commit 90310c3)

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sarthak Aggarwal <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Moving zstd compression codec as a plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Adding checks to EngineConfig and fixing tests

Signed-off-by: Prabhakar Sithanandam <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* fixing tests

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

* implementing codec aliases

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* moving codec aliases to custom codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* adding zstd default codec for backward compatibility

Signed-off-by: Sarthak Aggarwal <[email protected]>

* renaming to deprecated codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

---------

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Moving zstd compression codec as a plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Adding checks to EngineConfig and fixing tests

Signed-off-by: Prabhakar Sithanandam <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* fixing tests

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

* implementing codec aliases

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* moving codec aliases to custom codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* adding zstd default codec for backward compatibility

Signed-off-by: Sarthak Aggarwal <[email protected]>

* renaming to deprecated codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

---------

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
DarshitChanpura pushed a commit to DarshitChanpura/OpenSearch that referenced this pull request Sep 27, 2023
…pensearch-project#9832) (opensearch-project#9844)

* introducing zstd compression codec plugin

* Moving zstd compression codec as a plugin

* introducing zstd compression codec plugin

* Adding checks to EngineConfig and fixing tests

* incorporating review comments

* fixing tests

* introducing zstd compression codec plugin

* addressing review comments

* nit fixes

* implementing codec aliases

* addressing review comments

* review comments

* moving codec aliases to custom codec

* adding zstd default codec for backward compatibility

* renaming to deprecated codec

* incorporating review comments

* nit fixes

---------

(cherry picked from commit 76f1b52)

(cherry picked from commit 90310c3)

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sarthak Aggarwal <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
DarshitChanpura pushed a commit to DarshitChanpura/OpenSearch that referenced this pull request Sep 28, 2023
…pensearch-project#9832) (opensearch-project#9844)

* introducing zstd compression codec plugin

* Moving zstd compression codec as a plugin

* introducing zstd compression codec plugin

* Adding checks to EngineConfig and fixing tests

* incorporating review comments

* fixing tests

* introducing zstd compression codec plugin

* addressing review comments

* nit fixes

* implementing codec aliases

* addressing review comments

* review comments

* moving codec aliases to custom codec

* adding zstd default codec for backward compatibility

* renaming to deprecated codec

* incorporating review comments

* nit fixes

---------

(cherry picked from commit 76f1b52)

(cherry picked from commit 90310c3)

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sarthak Aggarwal <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Moving zstd compression codec as a plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* Adding checks to EngineConfig and fixing tests

Signed-off-by: Prabhakar Sithanandam <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* fixing tests

Signed-off-by: Sarthak Aggarwal <[email protected]>

* introducing zstd compression codec plugin

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

* implementing codec aliases

Signed-off-by: Sarthak Aggarwal <[email protected]>

* addressing review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* moving codec aliases to custom codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* adding zstd default codec for backward compatibility

Signed-off-by: Sarthak Aggarwal <[email protected]>

* renaming to deprecated codec

Signed-off-by: Sarthak Aggarwal <[email protected]>

* incorporating review comments

Signed-off-by: Sarthak Aggarwal <[email protected]>

* nit fixes

Signed-off-by: Sarthak Aggarwal <[email protected]>

---------

Signed-off-by: Sarthak Aggarwal <[email protected]>
Signed-off-by: Prabhakar Sithanandam <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Prabhakar Sithanandam <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demote] ZStd compression from GA / LTS to experimental and release a 2.9.1 patch
5 participants