Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null partSize in OnDemandBlockSnapshotIndexInput #9470

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Handle null partSize in OnDemandBlockSnapshotIndexInput #9470

merged 1 commit into from
Aug 23, 2023

Conversation

andrross
Copy link
Member

The partSize() value can be null if the underlying repository implementation does not implement file chunking.

Related Issues

Resolves #9291

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 61c5f17

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #9470 (1cdba2b) into main (0c839c3) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #9470      +/-   ##
============================================
- Coverage     71.11%   71.07%   -0.05%     
+ Complexity    57448    57400      -48     
============================================
  Files          4778     4778              
  Lines        270896   270897       +1     
  Branches      39583    39584       +1     
============================================
- Hits         192654   192534     -120     
- Misses        62006    62221     +215     
+ Partials      16236    16142      -94
Files Changed Coverage Δ
...e/remote/file/OnDemandBlockSnapshotIndexInput.java 80.00% <100.00%> (+2.72%) ⬆️

... and 462 files with indirect coverage changes

tlfeng
tlfeng reviewed Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@tlfeng tlfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very impressive to have detailed comment added! 👏

@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Aug 22, 2023
@kotwanikunal
Copy link
Member

@andrross Can you please rebase?

@andrross
Handle null partSize in OnDemandBlockSnapshotIndexInput
1cdba2b 
The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the handle-null-part-size branch from 3e64a63 to 1cdba2b Compare August 23, 2023 21:44
@andrross andrross requested a review from msfroh as a code owner August 23, 2023 21:44
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 1cdba2b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit c42ada8 into opensearch-project:main Aug 23, 2023
@andrross andrross deleted the handle-null-part-size branch August 23, 2023 23:03
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9470-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c42ada8e6d63295684303d46492216f3a6f94049
# Push it to GitHub
git push --set-upstream origin backport/backport-9470-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9470-to-2.x.

austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
@andrross @austintlee
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
c8ebc53 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
@andrross
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
5060a42 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
@andrross
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
2c6755f 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
@andrross @kkmr
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
1df5fde 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Kiran Reddy <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@andrross @kaushalmahi12
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
562982c 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@andrross @brusic
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
0b9c0fd 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
andrross added a commit to andrross/OpenSearch that referenced this pull request Feb 27, 2024
@andrross
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
9c94e57 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit c42ada8)
@andrross andrross mentioned this pull request Feb 27, 2024
Merged
8 tasks
kotwanikunal pushed a commit that referenced this pull request Feb 27, 2024
@andrross
Handle null partSize in OnDemandBlockSnapshotIndexInput (#9470) (#12485)
a1281f5 
The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit c42ada8)
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@andrross @shiv0408
Handle null partSize in OnDemandBlockSnapshotIndexInput (opensearch-p…
7cdc8c3 
…roject#9470)

The `partSize()` value can be null if the underlying repository
implementation does not implement file chunking.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng left review comments

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Searchable Snapshot not working with an NPE error
3 participants
@andrross @kotwanikunal @tlfeng