Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse #9410

Merged
merged 3 commits into from
Aug 23, 2023
Merged

[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse #9410

merged 3 commits into from
Aug 23, 2023

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

Today, we haven't reconstructed pit infos when deserialize GetAllPitNodesResponse, which causes corresponding field is empty.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 17, 2023 •
edited
Loading

Codecov Report

Merging #9410 (ea92a7b) into main (f3957ea) will decrease coverage by 0.07%.
Report is 19 commits behind head on main.
The diff coverage is 70.00%.

@@             Coverage Diff              @@
##               main    #9410      +/-   ##
============================================
- Coverage     71.24%   71.17%   -0.07%     
+ Complexity    57472    57453      -19     
============================================
  Files          4776     4776              
  Lines        270711   270721      +10     
  Branches      39574    39576       +2     
============================================
- Hits         192874   192699     -175     
- Misses        61610    61832     +222     
+ Partials      16227    16190      -37
Files Changed Coverage Δ
...java/org/opensearch/action/search/ListPitInfo.java 72.22% <40.00%> (+23.83%) ⬆️
...ensearch/action/search/GetAllPitNodesResponse.java 44.89% <100.00%> (+17.62%) ⬆️

... and 483 files with indirect coverage changes

@bugmakerrrrrr
Copy link
Contributor Author

hey @reta , do u mind taking a look?

@reta
Copy link
Collaborator

reta commented Aug 18, 2023

hey @reta , do u mind taking a look?

Nice catch, could you please add test case for that? Thank you!

@bugmakerrrrrr
Copy link
Contributor Author

hey @reta , do u mind taking a look?

Nice catch, could you please add test case for that? Thank you!

done

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 784a473

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@bugmakerrrrrr bugmakerrrrrr force-pushed the fix_get_all_pit_response branch from c22f5b1 to ea92a7b Compare August 23, 2023 05:16
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 5d3633c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta merged commit 980bf3c into opensearch-project:main Aug 23, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Aug 23, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 23, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2023
@github-actions
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (#…
ec21501 
…9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
(cherry picked from commit 980bf3c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
neetikasinghal pushed a commit to neetikasinghal/OpenSearch that referenced this pull request Aug 23, 2023
@bugmakerrrrrr @neetikasinghal
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
ce4ef15 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
reta pushed a commit that referenced this pull request Aug 23, 2023
@opensearch-trigger-bot @github-actions
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (#…
ea3c5af 
…9410) (#9510)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse



* add searializion test case



* run spotless



---------


(cherry picked from commit 980bf3c)

Signed-off-by: panguixin <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
@bugmakerrrrrr @austintlee
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
0f12179 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
@bugmakerrrrrr
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
6f1ce3a 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
@bugmakerrrrrr
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
d02a063 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
@bugmakerrrrrr @kkmr
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
abac53c 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Kiran Reddy <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@bugmakerrrrrr @kaushalmahi12
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
c69f374 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@bugmakerrrrrr @brusic
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
a4afe43 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@bugmakerrrrrr @shiv0408
[BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (o…
ee2dcb7 
…pensearch-project#9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugmakerrrrrr @reta