Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test testStatsOnShardUnassigned in RemoteStoreStatsIT #9057

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Aug 2, 2023

Description

This fixes the flaky test for different type of failures mentioned in the issue #9036.

  • Assertion count for successful shards
  • Due to node being stopped and failover not completing, during the teardown there were assertion failures on primaryMode.

Related Issues

Resolves #9036

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #9057 (ff67570) into main (11c8426) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

❗ Current head ff67570 differs from pull request most recent head 5f962aa. Consider uploading reports for the commit 5f962aa to get more accurate results

@@             Coverage Diff              @@
##               main    #9057      +/-   ##
============================================
- Coverage     71.03%   71.01%   -0.03%     
- Complexity    57229    57246      +17     
============================================
  Files          4765     4765              
  Lines        270293   270293              
  Branches      39533    39533              
============================================
- Hits         192013   191951      -62     
- Misses        62086    62216     +130     
+ Partials      16194    16126      -68     

see 458 files with indirect coverage changes

@ashking94 ashking94 force-pushed the 9036 branch 2 times, most recently from 7643fd7 to 379d19d Compare August 2, 2023 16:54
@ashking94 ashking94 requested a review from sohami as a code owner August 2, 2023 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:


> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/reporting.git with ref: main
Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 26m 53s

@mch2
Copy link
Member

mch2 commented Aug 2, 2023

https://github.com/opensearch-project/OpenSearch/pull/8718/files needs to be backported to 2.x that introduced this test

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/security-analytics.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 28m 22s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Gradle Check (Jenkins) Run Completed with:

@sachinpkale sachinpkale merged commit ff6a885 into opensearch-project:main Aug 3, 2023
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Aug 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 3, 2023
---------

Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit ff6a885)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah pushed a commit to VachaShah/OpenSearch that referenced this pull request Aug 3, 2023
kotwanikunal pushed a commit that referenced this pull request Aug 3, 2023
… (#9090)

---------


(cherry picked from commit ff6a885)

Signed-off-by: Ashish Singh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.remotestore.RemoteStoreStatsIT.testStatsOnShardUnassigned is flaky
5 participants