Remove distribution from main response in compatibility mode

[mch2]

This Change removes version.distribution when the version.number is
overridden with the cluster setting compatibility.override_main_response_version.

Signed-off-by: Marc Handalian [email protected]

Description

Removes the distribution property when in compatibility mode with 7.10.2.

curl without setting:

 curl localhost:9200/
{
  "name" : "runTask-0",
  "cluster_name" : "runTask",
  "cluster_uuid" : "vAOiFtLXSDqYXeCuItQGLA",
  "version" : {
    "distribution" : "opensearch",
    "number" : "1.0.0-SNAPSHOT",
    "build_type" : "tar",
    "build_hash" : "457f8e746edf13c3e519fd2622521787b822a478",
    "build_date" : "2021-06-29T04:15:13.028108Z",
    "build_snapshot" : true,
    "lucene_version" : "8.8.2",
    "minimum_wire_compatibility_version" : "6.8.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  }
}

turn on compatibility setting

curl -X PUT "localhost:9200/_cluster/settings?pretty" -H 'Content-Type: application/json' -d '{"persistent":{"compatibility":{"override_main_response_version":true}}}'
{
  "acknowledged" : true,
  "persistent" : {
    "compatibility" : {
      "override_main_response_version" : "true"
    }
  },
  "transient" : { }
}

curl localhost:9200/
{
  "name" : "runTask-0",
  "cluster_name" : "runTask",
  "cluster_uuid" : "vAOiFtLXSDqYXeCuItQGLA",
  "version" : {
    "number" : "7.10.2",
    "build_type" : "tar",
    "build_hash" : "457f8e746edf13c3e519fd2622521787b822a478",
    "build_date" : "2021-06-29T04:15:13.028108Z",
    "build_snapshot" : true,
    "lucene_version" : "8.8.2",
    "minimum_wire_compatibility_version" : "6.8.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  }
}

Issues Resolved

[#880]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

✅   DCO Check Passed 457f8e7

[opensearch-ci-bot]

✅   Gradle Wrapper Validation success 457f8e7

[opensearch-ci-bot]

✅   Gradle Precommit success 457f8e7

[adnapibar]

start gradle check

[opensearch-ci-bot]

✅   Gradle Check success 457f8e7
Log 265

Reports 265

[adnapibar]

LGTM

[DrissiReda]

This doesn't work if used through opensearch.yml config file using compatibility.override_main_response_version: true. It is simply ignored. Tested on version 1.3.4

[dblock]

This doesn't work if used through opensearch.yml config file using compatibility.override_main_response_version: true. It is simply ignored. Tested on version 1.3.4

Open a new bug please?