Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Search pipelines] Add Global Ignore_failure options for Processors #8637

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2004ba0 from #8373.

…8373)

* Add Global Ingore_failure options for Processors

Signed-off-by: Mingshi Liu <[email protected]>

* add changelog

Signed-off-by: Mingshi Liu <[email protected]>

* Add ignore_failure to 40_rename_response

Signed-off-by: Mingshi Liu <[email protected]>

* Change Boolean to boolean and refactor AbstractProcessor

Signed-off-by: Mingshi Liu <[email protected]>

* rename to isIgnoreFailure and add tests

Signed-off-by: Mingshi Liu <[email protected]>

* rename to isIgnoreFailure and add tests

Signed-off-by: Mingshi Liu <[email protected]>

* add ignoreFailure to runSearchPhaseResultsTransformer

Signed-off-by: Mingshi Liu <[email protected]>

* fix filter query and change log warn message

Signed-off-by: Mingshi Liu <[email protected]>

* Add test on matching each processor stat

Signed-off-by: Mingshi Liu <[email protected]>

* Add test on matching each processor stat

Signed-off-by: Mingshi Liu <[email protected]>

* remove extra spaces and words

Signed-off-by: Mingshi Liu <[email protected]>

* use IGNORE_FAILURE_KEY

Signed-off-by: Mingshi Liu <[email protected]>

---------

Signed-off-by: Mingshi Liu <[email protected]>
(cherry picked from commit 2004ba0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #8637 (2c196af) into 2.x (da59ae5) will increase coverage by 0.26%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##                2.x    #8637      +/-   ##
============================================
+ Coverage     70.47%   70.73%   +0.26%     
- Complexity    57009    57148     +139     
============================================
  Files          4745     4745              
  Lines        270660   270677      +17     
  Branches      39946    39949       +3     
============================================
+ Hits         190741   191476     +735     
+ Misses        63464    62761     -703     
+ Partials      16455    16440      -15     
Impacted Files Coverage Δ
...java/org/opensearch/search/pipeline/Processor.java 100.00% <ø> (ø)
...search/pipeline/common/ScriptRequestProcessor.java 30.00% <50.00%> (ø)
.../java/org/opensearch/search/pipeline/Pipeline.java 82.82% <68.75%> (-3.22%) ⬇️
...h/pipeline/common/FilterQueryRequestProcessor.java 96.00% <100.00%> (ø)
.../pipeline/common/RenameFieldResponseProcessor.java 94.59% <100.00%> (ø)
...java/org/opensearch/ingest/ConfigurationUtils.java 76.33% <100.00%> (ø)
.../opensearch/search/pipeline/AbstractProcessor.java 87.50% <100.00%> (ø)
...pensearch/search/pipeline/PipelineWithMetrics.java 90.82% <100.00%> (+0.17%) ⬆️

... and 464 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.state.CloseWhileRelocatingShardsIT.testCloseWhileRelocatingShards

@reta reta merged commit 149be07 into 2.x Jul 11, 2023
@github-actions github-actions bot deleted the backport/backport-8373-to-2.x branch July 11, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant