Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement buildEmptyAggregations for MultiTermsAggregator (#7089) #8333

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 86f955c from #7318.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

)

* Implement buildEmptyAggregations for MultiTermsAggregator (#7089)

Signed-off-by: Austin Lee <[email protected]>

* Address Spotless check issue

Signed-off-by: Austin Lee <[email protected]>

* Add a unit test for MultiTermsAggregator.buildEmptyAggregations (#7089)

Signed-off-by: Austin Lee <[email protected]>

* Update changelog

Update version check and reason

Signed-off-by: Austin Lee <[email protected]>

---------

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit 86f955c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the backport/backport-7318-to-2.x branch from 1d05e19 to 93d58b3 Compare June 29, 2023 12:54
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      3 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #8333 (93d58b3) into 2.x (2dbe33f) will decrease coverage by 0.06%.
The diff coverage is 56.95%.

@@             Coverage Diff              @@
##                2.x    #8333      +/-   ##
============================================
- Coverage     70.54%   70.49%   -0.06%     
- Complexity    56776    56868      +92     
============================================
  Files          4706     4714       +8     
  Lines        269087   269640     +553     
  Branches      39773    39855      +82     
============================================
+ Hits         189836   190079     +243     
- Misses        62886    63237     +351     
+ Partials      16365    16324      -41     
Impacted Files Coverage Δ
...va/org/opensearch/geometry/GeometryCollection.java 89.28% <0.00%> (-7.02%) ⬇️
...in/java/org/opensearch/wildfly/model/Employee.java 0.00% <ø> (ø)
...ildfly/transport/RestHighLevelClientActivator.java 0.00% <ø> (ø)
...transport/RestHighLevelClientEmployeeResource.java 0.00% <ø> (ø)
...wildfly/transport/RestHighLevelClientProducer.java 0.00% <ø> (ø)
...ly/transport/RestHighLevelJacksonJsonProvider.java 0.00% <ø> (ø)
...apshots/restore/RestoreSnapshotRequestBuilder.java 15.00% <0.00%> (-0.79%) ⬇️
...java/org/opensearch/index/fielddata/FieldData.java 70.48% <0.00%> (-3.11%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 69.27% <0.00%> (-3.56%) ⬇️
...dex/translog/transfer/TranslogTransferManager.java 78.45% <0.00%> (-1.33%) ⬇️
... and 30 more

... and 445 files with indirect coverage changes

@reta reta merged commit b12a45a into 2.x Jun 29, 2023
@github-actions github-actions bot deleted the backport/backport-7318-to-2.x branch June 29, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant