-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all guava #8107
Update all guava #8107
Conversation
Signed-off-by: Stephen Crawford <[email protected]>
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Stephen Crawford <[email protected]>
Thanks a lot @scrawfor99 ! |
Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
No problem :) |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8107 +/- ##
============================================
+ Coverage 70.92% 71.00% +0.07%
- Complexity 56664 56723 +59
============================================
Files 4722 4722
Lines 267604 267604
Branches 39214 39214
============================================
+ Hits 189803 190017 +214
+ Misses 61826 61585 -241
- Partials 15975 16002 +27
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @scrawfor99!
Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Stephen Crawford <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8107-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a31e159ad9965536e9f0a8ffce0f3d50243705a8
# Push it to GitHub
git push --set-upstream origin backport/backport-8107-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@scrawfor99 mind please backport manually? thank you |
* Backport guava Signed-off-by: Stephen Crawford <[email protected]> * fix exclusions Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]>
…pensearch-project#8114) * Backport guava Signed-off-by: Stephen Crawford <[email protected]> * fix exclusions Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]>
* Update all guava Signed-off-by: Stephen Crawford <[email protected]> * changelog Signed-off-by: Stephen Crawford <[email protected]> * remove ignors Signed-off-by: Stephen Crawford <[email protected]> * Fix ignores Signed-off-by: Stephen Crawford <[email protected]> * Update plugins/repository-gcs/build.gradle Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update plugins/repository-azure/build.gradle Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
* Update all guava Signed-off-by: Stephen Crawford <[email protected]> * changelog Signed-off-by: Stephen Crawford <[email protected]> * remove ignors Signed-off-by: Stephen Crawford <[email protected]> * Fix ignores Signed-off-by: Stephen Crawford <[email protected]> * Update plugins/repository-gcs/build.gradle Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> * Update plugins/repository-azure/build.gradle Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> --------- Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
When trying to resolve the dependencies for the gcs plugin, I noticed that in some places, we used the older Guava version. We can see here that everything before 32.0.1-jre has a vulnerability: https://mvnrepository.com/artifact/com.google.guava/guava.
Updating elsewhere just to be safe.
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.