Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [#7967] Adding back [Time series based workload desc order optimization throu… #8037

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[Backport 2.x] [#7967] Adding back [Time series based workload desc order optimization throu… #8037

merged 1 commit into from
Jun 13, 2023

Conversation

gashutos
Copy link
Contributor

Backport #7967

@gashutos
Adding back [Time series based workload desc order optimization throu…
df7032c 
…gh reverse segment read (opensearch-project#7244)] with fixes (opensearch-project#7967)

* Revert "Revert "Time series based workload desc order optimization through reverse segment read (opensearch-project#7244)" (opensearch-project#7892)"

This reverts commit bb26536.

Signed-off-by: gashutos <[email protected]>

* Enable time series optimization only if it is not IndexSorted index, also ASC order reverse should only consider in @timestamp field

Signed-off-by: gashutos <[email protected]>

* Modifying CHANGELOG

Signed-off-by: gashutos <[email protected]>

* Adding integ test for scroll API where sort by _doc is getting early termination

Signed-off-by: gashutos <[email protected]>

---------

Signed-off-by: gashutos <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #8037 (df7032c) into 2.x (c83c683) will decrease coverage by 0.08%.
The diff coverage is 35.71%.

@@             Coverage Diff              @@
##                2.x    #8037      +/-   ##
============================================
- Coverage     70.53%   70.45%   -0.08%     
+ Complexity    56657    56581      -76     
============================================
  Files          4696     4696              
  Lines        268499   268537      +38     
  Branches      39700    39714      +14     
============================================
- Hits         189376   189202     -174     
- Misses        62835    63024     +189     
- Partials      16288    16311      +23
Impacted Files Coverage Δ
.../main/java/org/opensearch/index/IndexSettings.java 86.29% <0.00%> (-0.67%) ⬇️
...va/org/opensearch/index/engine/InternalEngine.java 73.57% <0.00%> (+0.25%) ⬆️
...ensearch/search/internal/ContextIndexSearcher.java 71.60% <20.00%> (-5.73%) ⬇️
...va/org/opensearch/cluster/metadata/DataStream.java 84.15% <22.22%> (-6.06%) ⬇️
...ava/org/opensearch/index/mapper/MappingLookup.java 92.79% <50.00%> (-0.79%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 70.62% <66.66%> (+0.76%) ⬆️
...java/org/opensearch/index/engine/EngineConfig.java 98.50% <100.00%> (+0.04%) ⬆️
...g/opensearch/index/engine/EngineConfigFactory.java 92.95% <100.00%> (+0.10%) ⬆️

... and 459 files with indirect coverage changes

@sachinpkale
Copy link
Member

Codecov failed in original PR as well: #7967 (comment)

@gbbafna gbbafna merged commit 2b83949 into opensearch-project:2.x Jun 13, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
@gashutos @gaiksaya
Adding back [Time series based workload desc order optimization throu…
60b925e 
…gh reverse segment read (opensearch-project#7244)] with fixes (opensearch-project#7967) (opensearch-project#8037)

Signed-off-by: gashutos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gashutos @sachinpkale @gbbafna