Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version guards to deal for new query profile collector fields #7979

Merged

Conversation

ticheng-aws
Copy link
Contributor

@ticheng-aws ticheng-aws commented Jun 9, 2023

Description

#7975

Related Issues

Resolves #7355
https://github.com/opensearch-project/OpenSearch/pull/7975/files/fa83dc5a5e65953ce8a87e4adbee0f4ca2f2e230#r1223642855

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

@ticheng-aws ticheng-aws force-pushed the cs-query-profile-stats-change branch from 3eb66ff to d22ee60 Compare June 9, 2023 00:48
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Jun 9, 2023

The failure is fine, once we merge the backport to 2.x, the build will be green

@ticheng-aws ticheng-aws force-pushed the cs-query-profile-stats-change branch from d22ee60 to dc30628 Compare June 9, 2023 02:38
@ticheng-aws
Copy link
Contributor Author

The failure is fine, once we merge the backport to 2.x, the build will be green

Thanks, @reta. Please kindly review it again.

@ticheng-aws ticheng-aws requested a review from reta June 9, 2023 02:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #7979 (dc30628) into main (f27172b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7979      +/-   ##
============================================
- Coverage     71.01%   71.00%   -0.01%     
+ Complexity    56558    56549       -9     
============================================
  Files          4702     4702              
  Lines        266975   266975              
  Branches      39158    39158              
============================================
- Hits         189591   189573      -18     
- Misses        61397    61406       +9     
- Partials      15987    15996       +9     
Impacted Files Coverage Δ
...ensearch/search/profile/query/CollectorResult.java 94.53% <0.00%> (ø)

... and 438 files with indirect coverage changes

@reta reta merged commit 52326d7 into opensearch-project:main Jun 9, 2023
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
@ticheng-aws ticheng-aws self-assigned this Nov 2, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concurrent Segment Search] Query profile stats with concurrent execution of query phase
2 participants