-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version guards to deal for new query profile collector fields #7979
Merged
reta
merged 1 commit into
opensearch-project:main
from
ticheng-aws:cs-query-profile-stats-change
Jun 9, 2023
Merged
Update version guards to deal for new query profile collector fields #7979
reta
merged 1 commit into
opensearch-project:main
from
ticheng-aws:cs-query-profile-stats-change
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
1ecd199
to
3eb66ff
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
3eb66ff
to
d22ee60
Compare
reta
reviewed
Jun 9, 2023
reta
reviewed
Jun 9, 2023
server/src/main/java/org/opensearch/search/profile/query/CollectorResult.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
The failure is fine, once we merge the backport to |
Signed-off-by: Ticheng Lin <[email protected]>
d22ee60
to
dc30628
Compare
Thanks, @reta. Please kindly review it again. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7979 +/- ##
============================================
- Coverage 71.01% 71.00% -0.01%
+ Complexity 56558 56549 -9
============================================
Files 4702 4702
Lines 266975 266975
Branches 39158 39158
============================================
- Hits 189591 189573 -18
- Misses 61397 61406 +9
- Partials 15987 15996 +9
|
reta
approved these changes
Jun 9, 2023
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…pensearch-project#7979) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…pensearch-project#7979) Signed-off-by: Ticheng Lin <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7975
Related Issues
Resolves #7355
https://github.com/opensearch-project/OpenSearch/pull/7975/files/fa83dc5a5e65953ce8a87e4adbee0f4ca2f2e230#r1223642855
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.