Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default discovery-ec2 region to none. #7969

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 8, 2023

Description

Defaults discovery-ec2 plugin default region to none. According to https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/region-selection.html this should automatically determine the Region from the environment.

Related Issues

Resolves #7959.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member Author

dblock commented Jun 8, 2023

@raghuvanshraj do we need to do something similar for repository-s3?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #7969 (09de05f) into main (c888fce) will increase coverage by 0.02%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main    #7969      +/-   ##
============================================
+ Coverage     70.84%   70.87%   +0.02%     
+ Complexity    56464    56437      -27     
============================================
  Files          4702     4702              
  Lines        266973   266975       +2     
  Branches      39157    39158       +1     
============================================
+ Hits         189131   189207      +76     
+ Misses        61897    61808      -89     
- Partials      15945    15960      +15     
Impacted Files Coverage Δ
...rg/opensearch/discovery/ec2/AwsEc2ServiceImpl.java 89.06% <75.00%> (-1.27%) ⬇️
...rg/opensearch/discovery/ec2/Ec2ClientSettings.java 98.50% <100.00%> (ø)

... and 469 files with indirect coverage changes

@dblock dblock added the backport 2.x Backport to 2.x branch label Jun 8, 2023
@dblock dblock merged commit f27172b into opensearch-project:main Jun 8, 2023
@dblock dblock deleted the discovery-ec2-default-region branch June 8, 2023 17:12
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 8, 2023
Signed-off-by: dblock <[email protected]>
(cherry picked from commit f27172b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@raghuvanshraj
Copy link
Contributor

@raghuvanshraj do we need to do something similar for repository-s3?

I think this might be causing the failure in YAML rest tests and third party tests as well. Ref: #7866
I'll test out similar changes for repository-s3.

kotwanikunal pushed a commit that referenced this pull request Jun 8, 2023
(cherry picked from commit f27172b)

Signed-off-by: dblock <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock added a commit to dblock/OpenSearch that referenced this pull request Jun 8, 2023
sandeshkr419 pushed a commit to sandeshkr419/OpenSearch that referenced this pull request Jun 8, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…search-project#7971)

(cherry picked from commit f27172b)

Signed-off-by: dblock <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to form multi-node cluster using opensearch-cluster-cdk for 3.0.0
3 participants