-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document testing of discovery-ec2 and repository-s3. #7868
Conversation
@raghuvanshraj and @dreamer-89 care to contribute to this? |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7868 +/- ##
============================================
+ Coverage 70.84% 71.00% +0.16%
- Complexity 56530 56580 +50
============================================
Files 4714 4714
Lines 267213 267213
Branches 39182 39182
============================================
+ Hits 189310 189743 +433
+ Misses 61916 61483 -433
Partials 15987 15987
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreamer-89 Thanks for the review. Updated. Care to take another look? I'd like to err on the side of progress vs. perfection - we'll keep adding to these incrementally.
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Let's get one more review on discovery-ec2 doc.
@dblock : Need spotless fix on changes.
|
Signed-off-by: dblock <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Maybe @Bukhtawar ? |
Codecov is wrong. There's no code changes here. |
Tagging @raghuvanshraj @andrross @mch2 for review |
Signed-off-by: dblock <[email protected]> (cherry picked from commit 4228075) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 4228075) Signed-off-by: dblock <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ect#7868) (opensearch-project#8116) (cherry picked from commit 4228075) Signed-off-by: dblock <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ect#7868) Signed-off-by: dblock <[email protected]> Signed-off-by: Rishab Nahata <[email protected]>
…ect#7868) Signed-off-by: dblock <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This is a start for documenting testing for discovery-ec2 and repository-s3.
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.