Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document testing of discovery-ec2 and repository-s3. #7868

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 1, 2023

Description

This is a start for documenting testing for discovery-ec2 and repository-s3.

Related Issues

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member Author

dblock commented Jun 1, 2023

@raghuvanshraj and @dreamer-89 care to contribute to this?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Gradle Check (Jenkins) Run Completed with:

plugins/repository-s3/README.md Show resolved Hide resolved
plugins/repository-s3/README.md Outdated Show resolved Hide resolved
plugins/repository-s3/README.md Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #7868 (13d3a53) into main (52326d7) will increase coverage by 0.16%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #7868      +/-   ##
============================================
+ Coverage     70.84%   71.00%   +0.16%     
- Complexity    56530    56580      +50     
============================================
  Files          4714     4714              
  Lines        267213   267213              
  Branches      39182    39182              
============================================
+ Hits         189310   189743     +433     
+ Misses        61916    61483     -433     
  Partials      15987    15987              
Impacted Files Coverage Δ
.../org/opensearch/discovery/ec2/Ec2NameResolver.java 89.47% <0.00%> (ø)

... and 468 files with indirect coverage changes

Copy link
Member Author

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamer-89 Thanks for the review. Updated. Care to take another look? I'd like to err on the side of progress vs. perfection - we'll keep adding to these incrementally.

plugins/repository-s3/README.md Show resolved Hide resolved
plugins/repository-s3/README.md Show resolved Hide resolved
plugins/repository-s3/README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Let's get one more review on discovery-ec2 doc.

@dreamer-89
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

@dblock : Need spotless fix on changes.

* What went wrong:
Execution failed for task ':plugins:repository-s3:spotlessMiscCheck'.
> The following files had format violations:
      README.md
          @@ -22,4 +22,4 @@
           
           ```
           AWS_REGION=us-west-2·amazon_s3_access_key=$AWS_ACCESS_KEY_ID·amazon_s3_secret_key=$AWS_SECRET_ACCESS_KEY·amazon_s3_****_path=path·amazon_s3_bucket=dblock-opensearch·./gradlew·:plugins:repository-s3:s3ThirdPartyTest
          -```
          +```
  Run './gradlew :plugins:repository-s3:spotlessApply' to fix these violations.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchTaskCancellationWithHighCpu
      1 org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@dblock
Copy link
Member Author

dblock commented Jun 12, 2023

Maybe @Bukhtawar ?

@dblock
Copy link
Member Author

dblock commented Jun 13, 2023

Codecov is wrong. There's no code changes here.

@dreamer-89
Copy link
Member

Tagging @raghuvanshraj @andrross @mch2 for review

@dblock dblock merged commit 4228075 into opensearch-project:main Jun 16, 2023
@dblock dblock deleted the aws-docs branch June 16, 2023 18:51
@dblock dblock added the backport 2.x Backport to 2.x branch label Jun 16, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 16, 2023
Signed-off-by: dblock <[email protected]>
(cherry picked from commit 4228075)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89 pushed a commit that referenced this pull request Jun 16, 2023
(cherry picked from commit 4228075)

Signed-off-by: dblock <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…ect#7868) (opensearch-project#8116)

(cherry picked from commit 4228075)

Signed-off-by: dblock <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants