Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly attribute jboss-annotations-api as GPL-2.0-with-classpath-exception #7833

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented May 31, 2023

Description

When the jboss-annotations-api dependency was added, it was incorrectly given OpenSearch's own LICENSE and NOTICE text. This corrects it with the correct GPL-2.0-with-classpath-exception text from https://github.com/jboss/jboss-annotations-api_spec/blob/jboss-annotations-api_1.2_spec-1.0.2.Final/LICENSE and adds support to LicenseAnalyzer to identify it.

Related Issues

Noticed as part of #7820

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@Xtansia Xtansia force-pushed the fix/correct-jboss-annotations-license branch from f8e7cc4 to 0795047 Compare May 31, 2023 05:15
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #7833 (0795047) into main (a201400) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #7833      +/-   ##
============================================
- Coverage     70.92%   70.73%   -0.19%     
+ Complexity    56276    56168     -108     
============================================
  Files          4683     4683              
  Lines        266113   266115       +2     
  Branches      39075    39075              
============================================
- Hits         188749   188248     -501     
- Misses        61402    61975     +573     
+ Partials      15962    15892      -70     
Impacted Files Coverage Δ
...g/opensearch/gradle/precommit/LicenseAnalyzer.java 84.44% <100.00%> (+0.72%) ⬆️

... and 465 files with indirect coverage changes

@reta
Copy link
Collaborator

reta commented May 31, 2023

@Xtansia thanks for the fix, I was thinking to replace jboss-annotations-api with jakarta's one, I am not sure what we used the jboss's one before ...

@Xtansia Xtansia deleted the fix/correct-jboss-annotations-license branch May 31, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants