Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding serialization support for InetSocketAddress #7821

Conversation

parasjain1
Copy link
Contributor

Description

Adds support for serialization of InetSocketAddress in OpenSearch's custom serialization framework (StreamInput / StreamOutput ).

This is needed to support custom serialization in security plugin.

Related Issues

opensearch-project/security#2780

Check List

  • [ x ] New functionality includes testing.
    • [ x ] All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [ x ] Commits are signed per the DCO using --signoff
  • [ x ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@parasjain1 parasjain1 marked this pull request as draft May 30, 2023 06:46
…ss.getHostName()` in StreamOutput

Signed-off-by: Paras Jain <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@parasjain1 parasjain1 force-pushed the parasjaz-inetsocketaddress-serde branch from f16af6a to ce8a157 Compare May 30, 2023 11:21
@parasjain1 parasjain1 force-pushed the parasjaz-inetsocketaddress-serde branch from ce8a157 to c474f38 Compare May 30, 2023 11:22
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@parasjain1 parasjain1 force-pushed the parasjaz-inetsocketaddress-serde branch from c474f38 to 68af84a Compare May 30, 2023 11:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #7821 (68af84a) into main (0921ad7) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #7821      +/-   ##
============================================
- Coverage     70.89%   70.79%   -0.11%     
+ Complexity    56242    56205      -37     
============================================
  Files          4682     4682              
  Lines        266102   266115      +13     
  Branches      39070    39070              
============================================
- Hits         188658   188396     -262     
- Misses        61478    61758     +280     
+ Partials      15966    15961       -5     
Impacted Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 92.50% <ø> (-0.36%) ⬇️
...testore/stats/TransportRemoteStoreStatsAction.java 45.94% <100.00%> (+4.27%) ⬆️
...a/org/opensearch/common/io/stream/StreamInput.java 88.07% <100.00%> (+0.33%) ⬆️
.../org/opensearch/common/io/stream/StreamOutput.java 94.70% <100.00%> (+0.05%) ⬆️
...arch/index/remote/RemoteRefreshSegmentTracker.java 88.54% <100.00%> (+0.05%) ⬆️

... and 461 files with indirect coverage changes

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StreamInput and StreamOutput are being refactored to the core library. We no longer tightly couple types so InetAddress class now needs to use the Streamable registry just like GeoPoint and Instant. See #7780

@parasjain1
Copy link
Contributor Author

StreamInput and StreamOutput are being refactored to the core library. We no longer tightly couple types so InetAddress class now needs to use the Streamable registry just like GeoPoint and Instant. See #7780

Thanks for reviewing this @nknize. Will check the changes and proceed accordingly.

@parasjain1
Copy link
Contributor Author

Closing this PR as it's no longer required.

@parasjain1 parasjain1 closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants