-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding serialization support for InetSocketAddress #7821
adding serialization support for InetSocketAddress #7821
Conversation
Signed-off-by: Paras Jain <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
…ss.getHostName()` in StreamOutput Signed-off-by: Paras Jain <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
f16af6a
to
ce8a157
Compare
ce8a157
to
c474f38
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Paras Jain <[email protected]>
c474f38
to
68af84a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7821 +/- ##
============================================
- Coverage 70.89% 70.79% -0.11%
+ Complexity 56242 56205 -37
============================================
Files 4682 4682
Lines 266102 266115 +13
Branches 39070 39070
============================================
- Hits 188658 188396 -262
- Misses 61478 61758 +280
+ Partials 15966 15961 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StreamInput and StreamOutput are being refactored to the core library. We no longer tightly couple types so InetAddress class now needs to use the Streamable registry just like GeoPoint and Instant. See #7780
Closing this PR as it's no longer required. |
Description
Adds support for serialization of
InetSocketAddress
in OpenSearch's custom serialization framework (StreamInput / StreamOutput ).This is needed to support custom serialization in security plugin.
Related Issues
opensearch-project/security#2780
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.