Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote segments] Add backpressure in write path on segments lag between local and remote store (#7459) #7720

Merged
merged 1 commit into from
May 24, 2023

Conversation

ashking94
Copy link
Member

Description

This backports #7459

Related Issues

Resolves #7424

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #7720 (e039358) into 2.x (92571b7) will decrease coverage by 0.08%.
The diff coverage is 73.75%.

@@             Coverage Diff              @@
##                2.x    #7720      +/-   ##
============================================
- Coverage     70.61%   70.53%   -0.08%     
- Complexity    56364    56375      +11     
============================================
  Files          4663     4663              
  Lines        267530   267604      +74     
  Branches      39616    39626      +10     
============================================
- Hits         188907   188764     -143     
- Misses        62303    62576     +273     
+ Partials      16320    16264      -56     
Impacted Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...c/main/java/org/opensearch/index/IndexService.java 73.36% <ø> (-0.68%) ⬇️
...x/remote/RemoteRefreshSegmentPressureSettings.java 94.44% <ø> (-5.56%) ⬇️
...ain/java/org/opensearch/indices/IndicesModule.java 96.46% <0.00%> (-1.74%) ⬇️
...ensearch/action/bulk/TransportShardBulkAction.java 75.65% <14.28%> (-0.53%) ⬇️
...ex/remote/RemoteRefreshSegmentPressureService.java 77.50% <25.00%> (-4.65%) ⬇️
...ch/indices/cluster/IndicesClusterStateService.java 74.08% <33.33%> (+3.62%) ⬆️
...arch/index/remote/RemoteRefreshSegmentTracker.java 88.65% <63.63%> (+0.23%) ⬆️
...in/java/org/opensearch/index/shard/IndexShard.java 69.70% <66.66%> (-0.20%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 84.95% <83.20%> (+3.39%) ⬆️
... and 1 more

... and 432 files with indirect coverage changes

@gbbafna gbbafna merged commit 06fc7de into opensearch-project:2.x May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants