[Backport 2.x] Adding task cancellation timestamp in task API #7711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding task cancellation time in task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing unit tests and addressing comments Signed-off-by: Sagar Upadhyaya <[email protected]> * Adding change log for unreleased 2.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing running time cancel info from task API Signed-off-by: Sagar Upadhyaya <[email protected]> * Replacing long primitive with Long object Signed-off-by: Sagar Upadhyaya <[email protected]> * Making cancelledAt field human readable Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing failing test Signed-off-by: Sagar Upadhyaya <[email protected]> * Removing the feature from unreleased 3.x Signed-off-by: Sagar Upadhyaya <[email protected]> * Fixing ListTasksResponseTests failure Signed-off-by: Sagar Upadhyaya <[email protected]> * Test failure fix Signed-off-by: Sagar Upadhyaya <[email protected]> * Changing naming convention to cancellationStartTime Signed-off-by: Sagar Upadhyaya <[email protected]> --------- Signed-off-by: Sagar Upadhyaya <[email protected]> Signed-off-by: Sagar <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit 8d7a544) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sagar Upadhyaya <[email protected]>
sgup432
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
andrross
approved these changes
May 23, 2023
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7711 +/- ##
============================================
+ Coverage 70.33% 70.40% +0.06%
- Complexity 60120 60214 +94
============================================
Files 4899 4899
Lines 289129 289152 +23
Branches 41991 41994 +3
============================================
+ Hits 203359 203567 +208
+ Misses 68743 68530 -213
- Partials 17027 17055 +28
|
|
@dblock Can you review this backport PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports - #7445
Related Issues
#7445
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.