Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run publish maven snapshots on all branches matching pattern #7709

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented May 23, 2023

Description

Updates the branches that publish-maven-snapshots github workflow is run with. It now uses a regex to match any released of unreleased branches. I noticed that the .NET client was using the same patterns: https://github.com/opensearch-project/opensearch-net/blob/main/.github/workflows/test-jobs.yml#L16-L17

Related Issues

Resolves #7705

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Copy link
Member Author

cwperks commented May 23, 2023

Does this need a CHANGELOG entry?

@reta
Copy link
Collaborator

reta commented May 23, 2023

Does this need a CHANGELOG entry?

I think no, no code changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7709 (aaf72e1) into main (b4b3724) will increase coverage by 70.64%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #7709       +/-   ##
===========================================
+ Coverage        0   70.64%   +70.64%     
- Complexity      0    56108    +56108     
===========================================
  Files           0     4680     +4680     
  Lines           0   266081   +266081     
  Branches        0    39067    +39067     
===========================================
+ Hits            0   187983   +187983     
- Misses          0    62155    +62155     
- Partials        0    15943    +15943     

see 4680 files with indirect coverage changes

@cwperks
Copy link
Member Author

cwperks commented May 25, 2023

@gaiksaya @reta Is there anything outstanding for this PR? It should be good to go.

@reta
Copy link
Collaborator

reta commented May 25, 2023

@gaiksaya @reta Is there anything outstanding for this PR? It should be good to go.

Not from me, @gaiksaya LGTM?

@gaiksaya
Copy link
Member

gaiksaya commented May 25, 2023

Hey! So we won't be releasing anything before 1.3 so not sure if that regex should cover only 1.3 and 2.7.x
Basically since 2.7 is out nothing before that in 2.x series ever be released following semver. Do we still want to keep publishing to those versions?
Basically all we want is:

main
1.3
2.x
2.7 <--------- whatever automation creates version increment PRs modify it to bump this to 2.8 once 2.8 is released

Sample PR: #7371
@andrross @dblock Would like your input here.

@dblock
Copy link
Member

dblock commented May 29, 2023

@gaiksaya Are you saying hard-code that list? That seems alright by me. That list would be true for more than a year.

Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks requested a review from dbwiddis as a code owner May 30, 2023 15:22
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=tasks.list/10_basic/tasks_list test}

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=tasks.list/10_basic/tasks_list test}

@gaiksaya
Copy link
Member

@gaiksaya Are you saying hard-code that list? That seems alright by me. That list would be true for more than a year.

Yeah it is hard coded but branches like 2.7, 2.8 needs to be updated regularly so was recommending the version increment automation to accommodate this change as well. Looks like the current approach with regex works as well?

@gaiksaya gaiksaya merged commit 3741539 into opensearch-project:main May 31, 2023
@gaiksaya gaiksaya added backport 2.x Backport to 2.x branch backport 1.3 Backport to 1.3 branch backport 2.8 labels May 31, 2023
@gaiksaya
Copy link
Member

Adding above labels to backport to 2.x, 2.8 and 1.3 branches for now.
Thanks!

opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 3741539)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 3741539)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 31, 2023
Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 3741539)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 31, 2023
…7845)

(cherry picked from commit 3741539)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 31, 2023
…7846)

(cherry picked from commit 3741539)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 31, 2023
…7847)

(cherry picked from commit 3741539)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jun 2, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…rch-project#7709) (opensearch-project#7847)

(cherry picked from commit 3741539)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 Backport to 1.3 branch backport 2.x Backport to 2.x branch backport 2.8 skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Maven snapshots trigger missing for patch versions
4 participants