Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remote Translog] Trimming based on Remote Segment Store (#7383) #7699

Merged
merged 2 commits into from
May 24, 2023

Conversation

ashking94
Copy link
Member

  • [Remote Translog] Set min referenced as per remote segment store only when enabled. Add IT for failover using remote translog as well

Description

This backports #7383

Related Issues

#7381
#6195
#5670

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…project#7383)

* [Remote Translog] Set min referenced as per remote segment store only
when enabled. Add IT for failover using remote translog as well

Signed-off-by: Gaurav Bafna <[email protected]>
Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.index.remote.RemoteRefreshSegmentPressureServiceTests.testValidateSegmentUploadLag

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #7699 (f8042b4) into 2.x (b02bfd1) will increase coverage by 0.20%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##                2.x    #7699      +/-   ##
============================================
+ Coverage     70.37%   70.57%   +0.20%     
+ Complexity    60159    56370    -3789     
============================================
  Files          4899     4663     -236     
  Lines        289124   267556   -21568     
  Branches      41989    39614    -2375     
============================================
- Hits         203461   188834   -14627     
+ Misses        68605    62445    -6160     
+ Partials      17058    16277     -781     
Impacted Files Coverage Δ
.../org/opensearch/index/translog/TranslogWriter.java 74.30% <0.00%> (-0.80%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 75.00% <100.00%> (+0.30%) ⬆️
...n/java/org/opensearch/index/translog/Translog.java 83.19% <100.00%> (+0.84%) ⬆️
...dex/translog/transfer/TranslogTransferManager.java 82.82% <100.00%> (+0.21%) ⬆️

... and 691 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants