-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default search preference to _primary for searchable snapshot indices #7628
Change default search preference to _primary for searchable snapshot indices #7628
Conversation
8263985
to
5758b30
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
org.opensearch.common.xcontent.XContentParserTests.testString
|
Looks related to #7615 and unrelated to the changes in this PR. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7628 +/- ##
============================================
+ Coverage 70.72% 70.79% +0.07%
- Complexity 56044 56122 +78
============================================
Files 4676 4676
Lines 265969 265974 +5
Branches 39061 39063 +2
============================================
+ Hits 188102 188301 +199
+ Misses 61902 61746 -156
+ Partials 15965 15927 -38
|
Should be fixed, sorry about that @kotwanikunal |
server/src/internalClusterTest/java/org/opensearch/snapshots/SearchableSnapshotIT.java
Outdated
Show resolved
Hide resolved
…indices Signed-off-by: Kunal Kotwani <[email protected]>
5758b30
to
1a366c2
Compare
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fa878ae05ea2016bee99a8fc305ae506050f65d4
# Push it to GitHub
git push --set-upstream origin backport/backport-7628-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…indices (opensearch-project#7628) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Bharathwaj G <[email protected]>
…indices (opensearch-project#7628) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit fa878ae)
…indices (#7628) (#7696) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit fa878ae)
…indices (opensearch-project#7628) Signed-off-by: Kunal Kotwani <[email protected]>
…indices (opensearch-project#7628) Signed-off-by: Kunal Kotwani <[email protected]>
…indices (opensearch-project#7628) Signed-off-by: Kunal Kotwani <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
_primary
which was added as a part of Add back primary shard preference for queries #7375Related Issues
Resolves #7593
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.