Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default search preference to _primary for searchable snapshot indices #7628

Merged

Conversation

kotwanikunal
Copy link
Member

Description

Related Issues

Resolves #7593

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

org.opensearch.common.xcontent.XContentParserTests.testString

com.fasterxml.jackson.dataformat.yaml.JacksonYAMLParseException: The incoming YAML document exceeds the limit: 3145728 code points.
 at [Source: (byte[])"---
ow: "꠽꠾꠲꠱꠺꠸꠸꠼꠽꠽꠰꠲꠶꠱꠷꠴꠶꠽꠳꠸꠵꠴꠸꠻꠱꠸꠾꠽꠸꠶꠼꠰꠿꠱꠷꠵꠾꠲꠴꠱꠶꠰꠽꠻꠳꠱꠴꠳꠻꠰꠸꠺꠼꠳꠳꠳꠿꠻꠶꠾꠲꠺꠽꠺꠶꠽꠱꠿꠻꠿꠸꠴꠲꠶꠼꠵꠲\
  ꠿꠽꠵꠴꠺꠺꠳꠿꠹꠷꠲꠴꠿꠾꠿꠾꠷꠼꠷꠼꠸꠲꠶꠶꠶꠼꠴꠺꠱꠾꠴꠶꠰꠾꠾꠰꠱꠴꠼꠽꠿꠰꠳꠺꠰꠰꠺꠽꠼꠱꠰꠿꠵꠲꠱꠰꠼꠽꠽꠵꠽꠴꠼꠳꠴꠱꠱꠺꠺꠵꠷꠱꠰꠶꠷꠾꠺꠴꠸꠷\
  ꠷꠵꠵꠺"[truncated 9168338 bytes]; line: 37579, column: 20]

@kotwanikunal
Copy link
Member Author

Looks related to #7615 and unrelated to the changes in this PR.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #7628 (1a366c2) into main (eb51f2b) will increase coverage by 0.07%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #7628      +/-   ##
============================================
+ Coverage     70.72%   70.79%   +0.07%     
- Complexity    56044    56122      +78     
============================================
  Files          4676     4676              
  Lines        265969   265974       +5     
  Branches      39061    39063       +2     
============================================
+ Hits         188102   188301     +199     
+ Misses        61902    61746     -156     
+ Partials      15965    15927      -38     
Impacted Files Coverage Δ
...g/opensearch/cluster/routing/OperationRouting.java 80.35% <80.00%> (-0.02%) ⬇️

... and 447 files with indirect coverage changes

@reta
Copy link
Collaborator

reta commented May 19, 2023

Looks related to #7615 and unrelated to the changes in this PR.

Should be fixed, sorry about that @kotwanikunal

@kotwanikunal kotwanikunal force-pushed the primary-default-remote branch from 5758b30 to 1a366c2 Compare May 22, 2023 23:08
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit fa878ae into opensearch-project:main May 23, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7628-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fa878ae05ea2016bee99a8fc305ae506050f65d4
# Push it to GitHub
git push --set-upstream origin backport/backport-7628-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7628-to-2.x.

bharath-techie pushed a commit to bharath-techie/OpenSearch that referenced this pull request May 23, 2023
kotwanikunal added a commit to kotwanikunal/OpenSearch that referenced this pull request May 23, 2023
kotwanikunal added a commit that referenced this pull request May 23, 2023
…indices (#7628) (#7696)

Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit fa878ae)
suranjay pushed a commit to suranjay/OpenSearch that referenced this pull request May 29, 2023
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
@kotwanikunal kotwanikunal deleted the primary-default-remote branch July 12, 2023 19:53
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Searchable Snapshots] Use _primary as the default search preference for searchable snapshot indices
3 participants