[Backport 2.x] Remove LinkedDeque and replace with LinkedHashMap, Add filecache support in clear indices cache API #7595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#6968) * Remove LinkedDeque and replace with LinkedHashMap After the recent changes the usage of the LinkedDeque fits quite well with the insertion order semantics of LinkedHashMap, which also allows for constant time additions and removals. Signed-off-by: Andrew Ross <[email protected]> * Use class member reference now that lock is final Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Andrew Ross <[email protected]> (cherry picked from commit 65443ad)
kotwanikunal
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
…7498) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit a1e42b1) Signed-off-by: Kunal Kotwani <[email protected]>
kotwanikunal
force-pushed
the
backport-7498
branch
from
e412967 to
5603469
Compare
6 tasks
|
Post merge follow up: #7596 |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7595 +/- ##
============================================
- Coverage 70.17% 70.15% -0.03%
+ Complexity 59887 59829 -58
============================================
Files 4882 4882
Lines 288451 288328 -123
Branches 41931 41926 -5
============================================
- Hits 202427 202269 -158
- Misses 69045 69096 +51
+ Partials 16979 16963 -16
|
reta
approved these changes
May 17, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2.xRelated Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.