Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Reject invalid SearchBackpressureMode (#6832) (#7541) #7571

Merged

Conversation

andrross
Copy link
Member

ClusterState updates of SearchBackpressureMode are persisted without validation which causes the entire cluster to become unstable or corrupted when a cluster tries to load invalid mode.

Signed-off-by: Austin Lee [email protected]
(cherry picked from commit ba35781)

…search-project#7541)

* Reject invalid SearchBackpressureMode (opensearch-project#6832)

ClusterState updates of SearchBackpressureMode are persisted without
validation which causes the entire cluster to become unstable or
corrupted when a cluster tries to load invalid mode.

Signed-off-by: Austin Lee <[email protected]>
(cherry picked from commit ba35781)
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #7571 (7456c86) into 2.x (ead9495) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #7571      +/-   ##
============================================
- Coverage     70.38%   70.31%   -0.07%     
+ Complexity    59990    59933      -57     
============================================
  Files          4882     4882              
  Lines        288376   288376              
  Branches      41920    41920              
============================================
- Hits         202961   202778     -183     
- Misses        68430    68606     +176     
- Partials      16985    16992       +7     
Impacted Files Coverage Δ
.../backpressure/settings/SearchBackpressureMode.java 100.00% <100.00%> (+15.38%) ⬆️
...kpressure/settings/SearchBackpressureSettings.java 92.59% <100.00%> (ø)

... and 484 files with indirect coverage changes

@andrross andrross merged commit 2d8f25f into opensearch-project:2.x May 18, 2023
@andrross andrross deleted the backport/backport-7541-to-2.x branch May 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants