Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #7554

Merged
merged 1 commit into from
May 17, 2023
Merged

Fixed typo #7554

merged 1 commit into from
May 17, 2023

Conversation

AkM-2018
Copy link
Contributor

Description

Changed the hyphen to an underscore as discussed in issue #6448

Related Issues

Resolves: probably #3032 in documentation-website

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollWithOngoingSegmentReplication

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #7554 (7292f66) into main (f581ee2) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7554      +/-   ##
============================================
- Coverage     70.52%   70.46%   -0.06%     
- Complexity    59656    59672      +16     
============================================
  Files          4896     4896              
  Lines        286779   286779              
  Branches      41331    41331              
============================================
- Hits         202255   202084     -171     
- Misses        67830    68004     +174     
+ Partials      16694    16691       -3     
Impacted Files Coverage Δ
...luster/snapshots/create/CreateSnapshotRequest.java 69.93% <ø> (+1.22%) ⬆️

... and 510 files with indirect coverage changes

Signed-off-by: AkM-2018 <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@AkM-2018
Copy link
Contributor Author

This can be merged, right? It's just a typo change. Do I need to add an entry in CHANGELOG.md for this as well?

@andrross andrross added backport 2.x Backport to 2.x branch skip-changelog labels May 17, 2023
@andrross andrross merged commit aa97acd into opensearch-project:main May 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 17, 2023
Signed-off-by: AkM-2018 <[email protected]>
(cherry picked from commit aa97acd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request May 17, 2023
(cherry picked from commit aa97acd)

Signed-off-by: AkM-2018 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: AkM-2018 <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants