Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache Lucene to 9.6.0 #7505

Merged
merged 1 commit into from
May 10, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented May 10, 2023

Description

Update Apache Lucene to 9.6.0

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented May 10, 2023

Taking a look here at org.opensearch.indices.replication.SegmentReplicationIT.testReplicaHasDiffFilesThanPrimary, I believe this is flaky but will mute if its blocking this bump

@kotwanikunal
Copy link
Member

Strange. Just noticed gradle check is missing from the workflows.
image

Holding off on the merge.

@mch2
Copy link
Member

mch2 commented May 10, 2023

@kotwanikunal yeah I queued it to re-try https://github.com/opensearch-project/OpenSearch/actions/runs/4938705305 but its not appearing here

Copy link
Member

@kotwanikunal kotwanikunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending on the gradle check

@reta
Copy link
Collaborator Author

reta commented May 10, 2023

Pending on the gradle check

Github has issues ... again ..., but here is the check https://build.ci.opensearch.org/job/gradle-check/15187/

@reta
Copy link
Collaborator Author

reta commented May 10, 2023

Taking a look here at org.opensearch.indices.replication.SegmentReplicationIT.testReplicaHasDiffFilesThanPrimary, I believe this is flaky but will mute if its blocking this bump

Yes, it is: #6885

Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the update.lucene.9.6.0 branch from 8827842 to 8bcafeb Compare May 10, 2023 16:23
@reta
Copy link
Collaborator Author

reta commented May 10, 2023

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationRemoteStoreIT.testScrollWithOngoingSegmentReplication
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #7505 (8bcafeb) into main (78aa2e8) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##               main    #7505      +/-   ##
============================================
+ Coverage     70.52%   70.63%   +0.10%     
- Complexity    59677    59730      +53     
============================================
  Files          4887     4887              
  Lines        286610   286610              
  Branches      41315    41315              
============================================
+ Hits         202128   202439     +311     
+ Misses        67804    67527     -277     
+ Partials      16678    16644      -34     

see 471 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator Author

reta commented May 10, 2023

@kotwanikunal could you please unlock the merge? thank you

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for doing this!

@nknize nknize requested a review from kotwanikunal May 10, 2023 18:39
@nknize nknize dismissed kotwanikunal’s stale review May 10, 2023 18:40

No longer applicable. All tests pass

@nknize nknize merged commit 960fdd5 into opensearch-project:main May 10, 2023
@reta reta added the backport 2.x Backport to 2.x branch label May 10, 2023
reta added a commit to reta/OpenSearch that referenced this pull request May 10, 2023
reta added a commit to reta/OpenSearch that referenced this pull request May 10, 2023
reta added a commit that referenced this pull request May 11, 2023
dreamer-89 added a commit to dreamer-89/OpenSearch that referenced this pull request May 16, 2023
@reta reta removed their assignment Oct 3, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants