-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakiness of testQueryFiltering due to error bound #7317
Conversation
Signed-off-by: Austin Lee <[email protected]>
6a2c09b
to
f6f6f32
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7317 +/- ##
============================================
- Coverage 70.71% 70.64% -0.08%
+ Complexity 59497 59485 -12
============================================
Files 4859 4859
Lines 285339 285339
Branches 41133 41133
============================================
- Hits 201772 201570 -202
- Misses 66965 67181 +216
+ Partials 16602 16588 -14 |
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but cc:ing @tdunning in case we get our math wrong 😅
Signed-off-by: Austin Lee <[email protected]> (cherry picked from commit 611e007) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 611e007) Signed-off-by: Austin Lee <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#7317) Signed-off-by: Austin Lee <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This change addresses an inappropriate/incorrect error bound on TDigest estimates on medians used in MedianAbsoluteDeviationAggregatorTests. TDigest algorithm's error is proportional to q*(1-q) where q is the percentile and is at worst in the middle (median). 0.1 is more appropriate for 90 percentile (q = 0.9).
Issues Resolved
#4789
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.