-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ./gradlew build on MacOS (M1) by loudly disabling bwc tests. #7303
Conversation
Note that on my M1 the docker setup is failing (read-only filesystem?) so this test fails.
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7303 +/- ##
============================================
- Coverage 70.64% 70.59% -0.06%
+ Complexity 59512 59507 -5
============================================
Files 4862 4862
Lines 285544 285544
Branches 41153 41153
============================================
- Hits 201725 201566 -159
- Misses 67202 67428 +226
+ Partials 16617 16550 -67 see 494 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: dblock <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7303-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77f6d1353d9adfa54f440811867c056c48672ab3
# Push it to GitHub
git push --set-upstream origin backport/backport-7303-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…t#7303) Signed-off-by: dblock <[email protected]>
I am not going to bother manually backporting it to 2.x, but if someone wants to, please do! |
Chasing |
…t#7303) Signed-off-by: dblock <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Loudly disables bwc tests when running build on Mac. If we wanted to support a proper Mac distribution we would need to produce bwc artifacts for testing, which I believe means making a manual build once to get bootstrapped, then we would get rid of the
> Project :qa:full-cluster-restart declares a dependency from configuration 'opensearch_distro_extracted_testclusters-qa-full-cluster-restart-v2.1.1-1-2.1.1-' to configuration 'expanded-darwin-arm64-tar' which is not declared in the descriptor for project :distribution:bwc:bugfix.
error.Issues Resolved
Closes #4173.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.