[Segment Replication] - Remove redundant replica doc parsing on writes. #7279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. Signed-off-by: Marc Handalian <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #7279 +/- ##
============================================
- Coverage 70.58% 70.53% -0.06%
+ Complexity 59503 59475 -28
============================================
Files 4862 4862
Lines 285531 285544 +13
Branches 41153 41153
============================================
- Hits 201555 201414 -141
- Misses 67322 67560 +238
+ Partials 16654 16570 -84
... and 468 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mch2
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
nknize
approved these changes
Apr 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
…#7279) This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit 66e49a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
…#7279) This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit 66e49a6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nknize
pushed a commit
that referenced
this pull request
Apr 24, 2023
…#7279) (#7282) This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. (cherry picked from commit 66e49a6) Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nknize
pushed a commit
that referenced
this pull request
Apr 24, 2023
…#7279) (#7281) This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. (cherry picked from commit 66e49a6) Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
…opensearch-project#7279) This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. Signed-off-by: Marc Handalian <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…opensearch-project#7279) This change removes unnecessary doc parsing currently performed on replicas by updating applyIndexOperationOnReplicas to pass a doc id from the primary. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes unnecessary doc parsing currently performed on replicas.
Updates applyIndexOperationOnReplicas and applyDeleteOperationOnReplica to pass a doc id from the primary and construct a ParsedDocument manually with only the fields required to write to translog from NRTReplicationEngine.
The following benchmark was run on a 3 node cluster, SO dataset 60 shards 1 replica. Contender is with this patch.
Issues Resolved
closes #7164
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.