Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote refresh segment pressure service, settings and tracker #7227

Merged
merged 18 commits into from
May 2, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Apr 18, 2023

Description

This PR adds the required core classes for tracking remote refresh segment upload. This PR does not have the integration of the remote refresh segment pressure service with the remote refresh listener. #7219 has details on how the integration would look like. It would follow up in the next PR.

Issues Resolved

This solves #7226

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #7227 (c82ffb7) into main (72ed13b) will decrease coverage by 0.04%.
The diff coverage is 87.36%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7227      +/-   ##
============================================
- Coverage     70.55%   70.51%   -0.04%     
- Complexity    59441    59518      +77     
============================================
  Files          4862     4865       +3     
  Lines        285544   285816     +272     
  Branches      41153    41164      +11     
============================================
+ Hits         201453   201552      +99     
- Misses        67544    67680     +136     
- Partials      16547    16584      +37     
Impacted Files Coverage Δ
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...ex/remote/RemoteRefreshSegmentPressureService.java 82.14% <82.14%> (ø)
...arch/index/remote/RemoteRefreshSegmentTracker.java 83.19% <83.19%> (ø)
...java/org/opensearch/common/util/MovingAverage.java 100.00% <100.00%> (ø)
...x/remote/RemoteRefreshSegmentPressureSettings.java 100.00% <100.00%> (ø)

... and 465 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.basic.SearchWithRandomIOExceptionsIT.testRandomDirectoryIOExceptions
      1 org.opensearch.search.basic.SearchWithRandomIOExceptionsIT.classMethod

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicationPostDeleteAndForceMerge

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label May 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollWithOngoingSegmentReplication

@gbbafna gbbafna merged commit 18390f9 into opensearch-project:main May 2, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 2, 2023
)

Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit 18390f9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ashking94
Copy link
Member Author

Backport failing as the PR #6875 is yet to be backported which changes in classes referred in this PR.

linuxpi pushed a commit to linuxpi/OpenSearch that referenced this pull request May 19, 2023
@ashking94 ashking94 added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels May 23, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7227-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 18390f9e314f79aa53a251db788217c01732cf1c
# Push it to GitHub
git push --set-upstream origin backport/backport-7227-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7227-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants