Merging javadoc feature branch changes to main #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `./gradlew missingJavadoc` to validate missing javadocs. Currently this task fails because several modules are missing appropriate javadocs. Once added, this should pass. Also, precommit PomValidation check currently fails with missing Javadoc plugin, that needs to be fixed - opensearch-project#449 Thus keeping this in a separate feature branch. Signed-off-by: Himanshu Setia <[email protected]>
* Fix Javadoc errors in client/rest module Signed-off-by: Gregor Zurowski <[email protected]> * Add package info file in client/rest module Signed-off-by: Gregor Zurowski <[email protected]> * Fix typos Signed-off-by: Gregor Zurowski <[email protected]> * Add exception documentation to Javadoc Signed-off-by: Gregor Zurowski <[email protected]>
opensearch-project#707) * Fixes precommit task configuration failures due to newly added missingJavadoc task Signed-off-by: Himanshu Setia <[email protected]> * Fixes javadoc task errors due to PR#685 Signed-off-by: Himanshu Setia <[email protected]>
Signed-off-by: Himanshu Setia <[email protected]>
Signed-off-by: Himanshu Setia <[email protected]>
setiah
commented
May 17, 2021
setiah
commented
May 17, 2021
buildSrc/reaper/src/main/java/org/elasticsearch/gradle/reaper/package-info.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshu Setia <[email protected]>
|
✅ Gradle Wrapper Validation success f218934 |
|
✅ DCO Check Passed f218934 |
5 tasks
Signed-off-by: Himanshu Setia <[email protected]>
|
✅ Gradle Precommit success f218934 |
|
✅ DCO Check Passed 7ee64c0 |
|
✅ Gradle Wrapper Validation success 7ee64c0 |
|
✅ Gradle Precommit success 7ee64c0 |
tlfeng
reviewed
May 18, 2021
| @@ -30,6 +30,8 @@ | |||
|
|
|||
| apply plugin: 'opensearch.java' | |||
|
|
|||
| group = 'hdfs' | |||
There was a problem hiding this comment.
Is the name of the group fine? The above 2 names are fixture.xxx, but these 2 names without the fixture prefix.
There was a problem hiding this comment.
Yeah, that discrepancy exists from the legacy codebase. The imports inside hdfs module use package name as hdfs unlike other fixture modules. Probably we can fix the hdfs module in a separate PR.
tlfeng
approved these changes
May 18, 2021
|
start gradle check |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges changes in javadoc feature branch to main branch. It includes -
:client:rest(PR Fix Javadoc errors in moduleclient/rest#685)Issues Resolved
#449 , #221
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Himanshu Setia [email protected]