[Refactor] ClusterInfo to use j.util.Map instead of ImmutableOpenMap #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
added
enhancement
nknize
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Apr 13, 2023
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Apr 28, 2023
…pensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. Signed-off-by: Nicholas Walter Knize <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7126-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ee4c8a13c380f7cc2fb45dfc18ce22a30ca4c8bc
# Push it to GitHub
git push --set-upstream origin backport/backport-7126-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jun 23, 2023
…pensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jun 23, 2023
…pensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jun 23, 2023
…pensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
added a commit
that referenced
this pull request
Jun 26, 2023
…ableOpenMap to j.u.Map (#7126) (#7165) (#8241) * [Refactor] ClusterInfo to use j.util.Map instead of ImmutableOpenMap (#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. * [Refactor] Metadata members from ImmutableOpenMap to j.u.Map (#7165) Refactors Metadata.{indices, templates, customs} member variables from ImmutableOpenMap to use jdk Maps. Usage of these variables across the codebase is also refactored to use jdk maps. --------- Signed-off-by: Nicholas Walter Knize <[email protected]>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ableOpenMap to j.u.Map (opensearch-project#7126) (opensearch-project#7165) (opensearch-project#8241) * [Refactor] ClusterInfo to use j.util.Map instead of ImmutableOpenMap (opensearch-project#7126) With java.util.Map immutability and collection improvements the hppc ImmutableOpenMap is not needed in ClusterInfo. This commit refactors ClusterInfo to use java Maps and Immutable Collections and further trim the dependency on the aging hppc library. * [Refactor] Metadata members from ImmutableOpenMap to j.u.Map (opensearch-project#7165) Refactors Metadata.{indices, templates, customs} member variables from ImmutableOpenMap to use jdk Maps. Usage of these variables across the codebase is also refactored to use jdk maps. --------- Signed-off-by: Nicholas Walter Knize <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
java.util.Mapimmutability and collection improvements the hppcImmutableOpenMapis not needed inClusterInfo. This commit refactorsClusterInfoto use java Maps and Immutable Collections and further trim the dependency on the aging hppc library.relates #5910