-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Sets util from server to common lib #7090
Conversation
Refactos the Sets utility class from the server module to the common library. Signed-off-by: Nicholas Walter Knize <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Nicholas Walter Knize <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this retain the @opensearch.internal
label now that it is in the common lib?
For now I think it should. I haven't dug deep enough on this to see if this class should stay the way it is. We may want to consider refactoring it to a different utility method or package altogether. Keeping it marked internal will give us that freedom to reasses without guaranteeing bwc. |
Refactors the Sets utility class from the server module to the common library. Signed-off-by: Nicholas Walter Knize <[email protected]>
Refactors the Sets utility class from the server module to the common library. Signed-off-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit b5d9a3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#8230) Refactors the Sets utility class from the server module to the common library. Signed-off-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit b5d9a3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update changelog Signed-off-by: Nicholas Walter Knize <[email protected]> --------- Signed-off-by: Nicholas Walter Knize <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicholas Walter Knize <[email protected]>
…arch-project#7090) (opensearch-project#8230) Refactors the Sets utility class from the server module to the common library. Signed-off-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit b5d9a3f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update changelog Signed-off-by: Nicholas Walter Knize <[email protected]> --------- Signed-off-by: Nicholas Walter Knize <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Nicholas Walter Knize <[email protected]>
This simple PR refactors the Sets utility class from the server module to the common library util package.
relates #5910