Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Sets util from server to common lib #7090

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Apr 11, 2023

This simple PR refactors the Sets utility class from the server module to the common library util package.

relates #5910

Refactos the Sets utility class from the server module to the common
library.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Nicholas Walter Knize <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this retain the @opensearch.internal label now that it is in the common lib?

@nknize
Copy link
Collaborator Author

nknize commented Apr 11, 2023

For now I think it should. I haven't dug deep enough on this to see if this class should stay the way it is. We may want to consider refactoring it to a different utility method or package altogether. Keeping it marked internal will give us that freedom to reasses without guaranteeing bwc.

@nknize nknize merged commit b5d9a3f into opensearch-project:main Apr 11, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Apr 28, 2023
Refactors the Sets utility class from the server module to the common
library.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added the backport 2.x Backport to 2.x branch label Jun 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2023
Refactors the Sets utility class from the server module to the common
library.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit b5d9a3f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nknize added a commit that referenced this pull request Jun 23, 2023
…#8230)

Refactors the Sets utility class from the server module to the common
library.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit b5d9a3f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* update changelog

Signed-off-by: Nicholas Walter Knize <[email protected]>

---------

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nicholas Walter Knize <[email protected]>
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…arch-project#7090) (opensearch-project#8230)

Refactors the Sets utility class from the server module to the common
library.

Signed-off-by: Nicholas Walter Knize <[email protected]>
(cherry picked from commit b5d9a3f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* update changelog

Signed-off-by: Nicholas Walter Knize <[email protected]>

---------

Signed-off-by: Nicholas Walter Knize <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added v2.9.0 'Issues and PRs related to version v2.9.0' and removed v2.7.0 labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants