Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of protobuf-java to 3.22.2 #6994

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Apr 5, 2023

Description

There are 3 Gradle sub-projects declared protobuf-java dependency. They have got different version due to upgrade alone.
This PR will unify the version of library protobuf-java used in OpenSearch.

Changed the version for the below 3 libraries in 2 directories.
plugins/repository-gcs/build.gradle :

api 'com.google.protobuf:protobuf-java-util:3.22.2'
api 'com.google.protobuf:protobuf-java:3.22.2'

test/fixtures/hdfs-fixture/build.gradle :

api 'com.google.protobuf:protobuf-java:3.22.2'

There is another protobuf-java dependency declared in plugins/repository-hdfs/build.gradle, the version is already 3.22.2.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments dependencies Pull requests that update a dependency file v2.7.0 labels Apr 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov-commenter
Copy link

Codecov Report

Merging #6994 (838a479) into main (20b3ea6) will increase coverage by 0.00%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #6994   +/-   ##
=========================================
  Coverage     70.77%   70.77%           
- Complexity    59275    59297   +22     
=========================================
  Files          4823     4823           
  Lines        283985   283985           
  Branches      40953    40953           
=========================================
+ Hits         200993   200996    +3     
- Misses        66459    66491   +32     
+ Partials      16533    16498   -35     

see 479 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlfeng tlfeng merged commit 53b128f into opensearch-project:main Apr 6, 2023
@tlfeng tlfeng added backport 2.x Backport to 2.x branch and removed backport PRs or issues specific to backporting features or enhancments labels Apr 6, 2023
@tlfeng tlfeng deleted the protobuf-java-3.22.2 branch April 6, 2023 05:13
tlfeng pushed a commit to tlfeng/OpenSearch that referenced this pull request Apr 6, 2023
* Bump version of protobuf-java to 3.22.2

Signed-off-by: Tianli Feng <[email protected]>

(cherry picked from commit 53b128f)
Signed-off-by: Tianli Feng <[email protected]>
tlfeng pushed a commit that referenced this pull request Apr 6, 2023
(cherry picked from commit 53b128f)
Signed-off-by: Tianli Feng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch dependencies Pull requests that update a dependency file v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants