-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Fix flaky testReplicaHasDiffFilesThanPrimary test #6979
[Segment Replication] Fix flaky testReplicaHasDiffFilesThanPrimary test #6979
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@kotwanikunal @peterzhuamazon : Is this a known issue ?
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Suraj Singh <[email protected]>
Signed-off-by: Suraj Singh <[email protected]>
30582a4
to
4d6b655
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6979 +/- ##
============================================
- Coverage 70.78% 70.73% -0.05%
- Complexity 59305 59326 +21
============================================
Files 4813 4823 +10
Lines 283781 284010 +229
Branches 40924 40949 +25
============================================
+ Hits 200864 200886 +22
- Misses 66420 66625 +205
- Partials 16497 16499 +2
... and 480 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…st (#6979) * [Segment Replication] Fix flaky testReplicaHasDiffFilesThanPrimary test Signed-off-by: Suraj Singh <[email protected]> * Use existing doc assertion methods Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> (cherry picked from commit 4511354) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…st (opensearch-project#6979) * [Segment Replication] Fix flaky testReplicaHasDiffFilesThanPrimary test Signed-off-by: Suraj Singh <[email protected]> * Use existing doc assertion methods Signed-off-by: Suraj Singh <[email protected]> --------- Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: Valentin Mitrofanov <[email protected]>
…st (#6979) (#6989) * [Segment Replication] Fix flaky testReplicaHasDiffFilesThanPrimary test * Use existing doc assertion methods --------- (cherry picked from commit 4511354) Signed-off-by: Suraj Singh <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Fixes the flakyness of this test by waiting for cluster to process the replica shard failure. Without this wait, doc ingestion & shard cancellation run in parallel. The test also uses existing utilities used for doc count assertion which waits for a longer time i.e.
1 minute
. Ran test with fix 100 times without failure.Issues Resolved
Resolves #6885
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.