Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Avoid negative memory result in IndicesQueryCache stats calculation #6965

Merged

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Apr 4, 2023

Backport c0a8cf8 from #6917.

(opensearch-project#6917)

* Avoid negative memory result in IndicesQueryCache stats calculation

* Cache stores recent queries so isn't empty even with no doc id sets

Signed-off-by: Daniel Widdis <[email protected]>

* Add test which actually fails without the bug fix

Signed-off-by: Daniel Widdis <[email protected]>

---------

Signed-off-by: Daniel Widdis <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=pit/10_basic/Delete all}

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #6965 (5bf84ae) into 2.x (535cbac) will increase coverage by 0.19%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #6965      +/-   ##
============================================
+ Coverage     70.28%   70.47%   +0.19%     
- Complexity    59527    59592      +65     
============================================
  Files          4824     4824              
  Lines        286330   286332       +2     
  Branches      41626    41627       +1     
============================================
+ Hits         201250   201799     +549     
+ Misses        68279    67617     -662     
- Partials      16801    16916     +115     
Impacted Files Coverage Δ
...java/org/opensearch/indices/IndicesQueryCache.java 88.48% <100.00%> (-2.76%) ⬇️

... and 480 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocation

@owaiskazi19 owaiskazi19 merged commit ef74d54 into opensearch-project:2.x Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants