-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Refactor] Remove CollectionUtils.sortAndDedup and use java TreeSet instead of hppc ObjectArrayList #6902
Conversation
…nstead of hppc ObjectArrayList (#6884) * [Refactor] CollectionUtils.sortAndDedup to use java lists HPPC ObjectArrayLists provide no benefit in CollectionUtils.sortAndDedup and adds an unnecessary library dependency. This commit removes that dependency on hppc by switching the sortAndDeup method to use java.util.Lists. BinaryFieldMapper logic is updated to use the generic java list. Signed-off-by: Nicholas Walter Knize <[email protected]> * close BytesStreamOutput in CustomBinaryDocValuesField.bytes Signed-off-by: Nicholas Walter Knize <[email protected]> --------- Signed-off-by: Nicholas Walter Knize <[email protected]> (cherry picked from commit 4859e15) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6902 +/- ##
============================================
- Coverage 70.41% 70.30% -0.12%
+ Complexity 59480 59437 -43
============================================
Files 4810 4811 +1
Lines 285453 285537 +84
Branches 41503 41508 +5
============================================
- Hits 200993 200735 -258
- Misses 67704 68037 +333
- Partials 16756 16765 +9
... and 466 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Backport 4859e15 from #6884.