-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance search preference based routing for WRR #6834
Enhance search preference based routing for WRR #6834
Conversation
Gradle Check (Jenkins) Run Completed with:
|
7473ec0
to
d0ae3d8
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6834 +/- ##
============================================
+ Coverage 70.65% 70.67% +0.01%
- Complexity 59162 59205 +43
============================================
Files 4812 4812
Lines 283615 283631 +16
Branches 40896 40898 +2
============================================
+ Hits 200394 200443 +49
+ Misses 66764 66728 -36
- Partials 16457 16460 +3
... and 494 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
256ba08
to
dc9ab0d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
55ef13d
to
dc9ab0d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create an issue where we list out the problems which this PR is solving ?
@gbbafna i've created issues corresponding to this PR and updated description |
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Varun Bansal <[email protected]>
Signed-off-by: Varun Bansal <[email protected]>
4be3054
to
0f7e026
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6834-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d8d6e7324adb4be088cab8e1fa5833e18ef19109
# Push it to GitHub
git push --set-upstream origin backport/backport-6834-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
) Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
Signed-off-by: Varun Bansal <[email protected]> (cherry picked from commit d8d6e73)
) Signed-off-by: Varun Bansal <[email protected]> Signed-off-by: Valentin Mitrofanov <[email protected]>
Description
Various enhancements to search preference for Weighed Round Robin shard routing
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.